Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove skipping MV3 e2e tests for hardware wallet #24688

Closed
DDDDDanica opened this issue May 21, 2024 · 0 comments · Fixed by #25039
Closed

Remove skipping MV3 e2e tests for hardware wallet #24688

DDDDDanica opened this issue May 21, 2024 · 0 comments · Fixed by #25039
Assignees
@danjm
Labels
team-extension-platform

Comments

@DDDDDanica
Copy link
Contributor

Image

Currently the e2e tests for hardware wallet is skipped for MV3, this will be restored once #21496 is merged
@DDDDDanica DDDDDanica self-assigned this May 21, 2024
@metamaskbot metamaskbot added the INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. label May 21, 2024
@DDDDDanica DDDDDanica removed the INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. label May 21, 2024
@danjm danjm assigned danjm and unassigned DDDDDanica Jun 4, 2024
@itsyoboieltr itsyoboieltr mentioned this issue Jun 4, 2024
Merged
7 tasks
DDDDDanica pushed a commit that referenced this issue Jun 10, 2024
@itsyoboieltr
fix: hardware wallet e2e test mv3 support (#25039)
0a65a61 
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/25039?quickstart=1)

This PR removes the skip for the e2e test named `Connects to a Hardware
wallet for lattice`. After removing the skip, I also discovered that the
test fails, because the case where MV3 is enabled was not handled. This
was rectified accordingly.

## **Related issues**

Fixes: #24688 

## **Manual testing steps**

1. yarn test:e2e:single test/e2e/tests/account/import-flow.spec.js

## **Screenshots/Recordings**

Not applicable, no visual changes.

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danjm danjm

Labels
team-extension-platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: hardware wallet e2e test mv3 support
3 participants
@danjm @DDDDDanica @metamaskbot