Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): [email protected]>7.11.1 #24980

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Jun 2, 2024

Description

  • Upgrade rpc-websockets (used by @solana/web3.js used by @trezor/ packages).
    • Fixes broken and deprecated 7.11.0.
    • Context
    • Resolves failing yarn audit check.

Open in GitHub Codespaces

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Jun 2, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@legobeat legobeat added dependencies Pull requests that update a dependency file team-security labels Jun 2, 2024
@legobeat legobeat marked this pull request as ready for review June 2, 2024 22:52
@legobeat legobeat requested a review from a team as a code owner June 2, 2024 22:52
@legobeat legobeat force-pushed the deps-fix-rpc-websockets branch 2 times, most recently from d63d3ea to 981eddd Compare June 2, 2024 23:31
@legobeat legobeat requested a review from a team June 3, 2024 01:09
@legobeat legobeat force-pushed the deps-fix-rpc-websockets branch 2 times, most recently from 9453803 to fe5e3cd Compare June 3, 2024 01:33
@legobeat legobeat force-pushed the deps-fix-rpc-websockets branch 4 times, most recently from adb6c62 to de4955d Compare June 3, 2024 03:04
legobeat added a commit to legobeat/metamask-extension that referenced this pull request Jun 3, 2024
legobeat added a commit to legobeat/metamask-extension that referenced this pull request Jun 3, 2024
legobeat added a commit to legobeat/metamask-extension that referenced this pull request Jun 3, 2024
legobeat added a commit to legobeat/metamask-extension that referenced this pull request Jun 3, 2024
legobeat added a commit to legobeat/metamask-extension that referenced this pull request Jun 3, 2024
@legobeat legobeat force-pushed the deps-fix-rpc-websockets branch from de4955d to 84ec1e0 Compare June 3, 2024 03:23
legobeat added a commit to legobeat/metamask-extension that referenced this pull request Jun 3, 2024
legobeat added a commit to legobeat/metamask-extension that referenced this pull request Jun 3, 2024
legobeat added a commit to legobeat/metamask-extension that referenced this pull request Jun 3, 2024
legobeat added a commit to legobeat/metamask-extension that referenced this pull request Jun 3, 2024
legobeat added a commit to legobeat/metamask-extension that referenced this pull request Jun 3, 2024
@legobeat legobeat force-pushed the deps-fix-rpc-websockets branch from 84ec1e0 to e6ffa78 Compare June 3, 2024 03:47
legobeat added a commit to legobeat/metamask-extension that referenced this pull request Jun 3, 2024
legobeat added a commit to legobeat/metamask-extension that referenced this pull request Jun 3, 2024
legobeat added a commit to legobeat/metamask-extension that referenced this pull request Jun 3, 2024
legobeat added a commit to legobeat/metamask-extension that referenced this pull request Jun 3, 2024
legobeat added a commit to legobeat/metamask-extension that referenced this pull request Jun 3, 2024
@legobeat legobeat force-pushed the deps-fix-rpc-websockets branch from e6ffa78 to 3427e23 Compare June 3, 2024 04:11
legobeat added a commit to legobeat/metamask-extension that referenced this pull request Jun 3, 2024
legobeat added a commit to legobeat/metamask-extension that referenced this pull request Jun 3, 2024
legobeat added a commit to legobeat/metamask-extension that referenced this pull request Jun 3, 2024
Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.70%. Comparing base (71e4a5d) to head (3427e23).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #24980      +/-   ##
===========================================
- Coverage    65.70%   65.70%   -0.00%     
===========================================
  Files         1366     1366              
  Lines        54361    54361              
  Branches     14141    14141              
===========================================
- Hits         35715    35714       -1     
- Misses       18646    18647       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

legobeat added a commit to legobeat/metamask-extension that referenced this pull request Jun 3, 2024
legobeat added a commit to legobeat/metamask-extension that referenced this pull request Jun 3, 2024
legobeat added a commit to legobeat/metamask-extension that referenced this pull request Jun 3, 2024
legobeat added a commit to legobeat/metamask-extension that referenced this pull request Jun 3, 2024
legobeat added a commit to legobeat/metamask-extension that referenced this pull request Jun 3, 2024
@legobeat legobeat merged commit 07f1eb4 into MetaMask:develop Jun 3, 2024
77 checks passed
@legobeat legobeat deleted the deps-fix-rpc-websockets branch June 3, 2024 05:15
@github-actions github-actions bot locked and limited conversation to collaborators Jun 3, 2024
@legobeat
Copy link
Contributor Author

legobeat commented Jun 3, 2024

This did not actually fix the issue; changes still needed in intermediary packages.

solana-labs/solana-web3.js#2758

@metamaskbot metamaskbot added the release-11.16.6 Issue or pull request that will be included in release 11.16.6 label Jun 4, 2024
@metamaskbot
Copy link
Collaborator

No release label on PR. Adding release label release-11.16.6 on PR, as PR was cherry-picked in branch 11.16.6.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file release-11.16.6 Issue or pull request that will be included in release 11.16.6 team-security
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants