fix: bump assets controller to 30.0.0 #24913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
I'm looking through remaining occurrences of |
legobeat
reviewed
May 30, 2024
for nonce-tracker/block-tracker bump
The currently replaced versions are verified compatible. Fixes nonce-tracker issue
salimtb
force-pushed
the
bump-assets-controller-version
branch
from
6dd2c8d to
c4ec3b2
Compare
salimtb
added
team-assets
needs-assets-ux-review
|
@metamaskbot update-policies |
|
Policies updated |
…metamask-extension into bump-assets-controller-version
…metamask-extension into bump-assets-controller-version
7 tasks
|
NFT detection flow works as expected. Screen.Recording.2024-06-04.at.15.08.44.mov |
|
I confirm that i have seen same behavior happen when trying to send an ERC2O. Screen.Recording.2024-06-04.at.15.16.05.mov |
Builds ready [87dd240]
Page Load Metrics (51 ± 4 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [9fb556f]
Page Load Metrics (141 ± 173 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
bergeron
previously approved these changes
Jun 4, 2024
7 tasks
danjm
reviewed
Jun 4, 2024
| "oidc.api.cx.metamask.io" | ||
| "oidc.api.cx.metamask.io", | ||
| "price.api.cx.metamask.io", | ||
| "token.api.cx.metamask.io" |
There was a problem hiding this comment.
Given the inclusion of "token.api.cx.metamask.io" should "token-api.metaswap.codefi.network", be removed?
There was a problem hiding this comment.
I tried to remove it, but there was still a usage somewhere. I will tackle it separately from this upgrade.
There was a problem hiding this comment.
Looks like it's becuase this comes from @metamask/controller-utils, and since this PR introduces the new version but is still using the older one(s) simultaneously, it will hit a different endpoint depending on which of the versions is used.
zone-live
added a commit
that referenced
this pull request
Jun 5, 2024
> [!NOTE] > This PR is intended to be cherry-picked into RC 11.17.0 after being merged into develop ## **Description** Upgrade transaction-controller to get this fix: MetaMask/core#4343 [](https://codespaces.new/MetaMask/metamask-extension/pull/24947?quickstart=1) ## **Related issues** Fixes: A recent update to the transaction-controller has made the TransactionMeta object passed to the afterSign hook frozen. This change prevents adding new properties, leading to the error: “Cannot add property custodyId, object is not extensible.” This bug is breaking all transactions for MMI as the original txMeta cannot store required properties like custodyId. Blocked by #24861 Blocked by #24913 ## **Manual testing steps** I followed these steps to test the fix: 1. yarn && yarn start:mmi 2. create a new wallet 3. visit https://saturn-custody-ui.dev.metamask-institutional.io/ and add two custodial addresses 4. send 0ETH from one custodial address to the other You should see a popup with an Approve button. Before this fix, the transaction would appear in the activity tab with an error. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: MetaMask Bot <[email protected]> Co-authored-by: Antonio Regadas <[email protected]>
danjm
previously approved these changes
Jun 5, 2024
Merged
7 tasks
bergeron
approved these changes
Jun 5, 2024
danjm
approved these changes
Jun 5, 2024
](https://codespaces.new/MetaMask/metamask-extension/pull/24947?quickstart=1){kind=link}
gauthierpetetin
added
the
release-12.0.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrades to version 30 of assets controllers, bringing a new
marketDataobject to the token rates controller.Related issues
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist