cherry-pick: Fix increaseAllowance bugs
#23929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedronfigueiredo
added
team-confirmations-secure-ux
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
## **Description** Fixes two bugs: one related to the site suggested value and another to the function name on the view details panel. See linked issues for repro instructions. [](https://codespaces.new/MetaMask/metamask-extension/pull/23897?quickstart=1) ## **Related issues** Fixes: #23884 and #23885 ## **Manual testing steps** 1. Go to test dApp 2. Deploy an erc20 contract 3. Click increase token allowance ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **After** ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
pedronfigueiredo
force-pushed
the
pnf-increase-allowance-bugfix-cp
branch
from
600ae4a
to
13e2c42
Compare
Builds ready [13e2c42]
Page Load Metrics (581 ± 413 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
](https://codespaces.new/MetaMask/metamask-extension/pull/23897?quickstart=1){kind=link}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
This Cherry-pick should be merged after #23883 only!
Description
Fixes two bugs: one related to the site suggested value and another to the function name on the view details panel. See linked issues for repro instructions.
Related issues
Fixes: #23884 and #23885
Manual testing steps
Screenshots/Recordings
After
Pre-merge author checklist
Pre-merge reviewer checklist