-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cherry-pick: Adds confirmation screen for 'increaseAllowance' (#23560) #23883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedronfigueiredo
added
team-confirmations-secure-ux
DEPRECATED: please use "team-confirmations" label instead
release-blocker
This bug is blocking the next release
team-confirmations-secure-ux-PR
PRs from the confirmations team
labels
Apr 8, 2024
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
pedronfigueiredo
force-pushed
the
pnf/increase-allowance-cherry-pick
branch
from
April 8, 2024 09:57
c736dd9
to
ddc151a
Compare
pedronfigueiredo
changed the title
feat(): Adds confirmation screen for 'increaseAllowance' (#23560)
cherry-pick: Adds confirmation screen for 'increaseAllowance' (#23560)
Apr 8, 2024
pedronfigueiredo
force-pushed
the
pnf/increase-allowance-cherry-pick
branch
from
April 8, 2024 11:37
ddc151a
to
8c4491b
Compare
@metamaskbot update-policies |
Policies updated |
pedronfigueiredo
force-pushed
the
pnf/increase-allowance-cherry-pick
branch
2 times, most recently
from
April 8, 2024 16:49
b1e77dd
to
27b6908
Compare
@metamaskbot update-policies |
Policies updated |
pedronfigueiredo
force-pushed
the
pnf/increase-allowance-cherry-pick
branch
from
April 9, 2024 12:48
6fe3bbb
to
34b50f5
Compare
Builds ready [874039d]
Page Load Metrics (498 ± 406 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
~**NOTE: This PR is blocked by [changes to core repo](MetaMask/core#4069) as well as to the [test dApp](MetaMask/test-dapp#304) first.**~ Reuses the token approve confirmation screen for 'increaseAllowance'. It also includes an e2e test for the complete flow. [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/23560?quickstart=1) Fixes: [#2224](MetaMask/MetaMask-planning#2224) 1. Go to the test dApp 2. Create a token 3. Approve token for a small amount 4. Try to transfer a higher amount of tokens from another account. (it should fail) 5. Go back to the first account and increase the allowance. 6. Try to transfer again from the second account. (it should succeed) <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> <img width="472" alt="Screenshot 2024-03-18 at 17 54 12" src="https://github.com/MetaMask/metamask-extension/assets/13814744/243a529b-4710-419b-8764-f2c06be5a903"> <img width="472" alt="Screenshot 2024-03-18 at 17 54 38" src="https://github.com/MetaMask/metamask-extension/assets/13814744/03843cf3-477d-4dbb-8c24-ae3b808a766f"> - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've clearly explained what problem this PR is solving and how it is solved. - [x] I've linked related issues - [x] I've included manual testing steps - [x] I've included screenshots/recordings if applicable - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [x] I’ve properly set the pull request status: - [x] In case it's not yet "ready for review", I've set it to "draft". - [x] In case it's "ready for review", I've changed it from "draft" to "non-draft". - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
pedronfigueiredo
force-pushed
the
pnf/increase-allowance-cherry-pick
branch
from
April 10, 2024 09:36
874039d
to
c8c4474
Compare
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-blocker
This bug is blocking the next release
team-confirmations-secure-ux
DEPRECATED: please use "team-confirmations" label instead
team-confirmations-secure-ux-PR
PRs from the confirmations team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This PR is blocked by changes to corerepo as well as to the test dApp first.
Reuses the token approve confirmation screen for 'increaseAllowance'. It also includes an e2e test for the complete flow.
Fixes:
#2224
I’ve followed MetaMask Coding Standards.
I've clearly explained what problem this PR is solving and how it is solved.
I've linked related issues
I've included manual testing steps
I've included screenshots/recordings if applicable
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
I’ve properly set the pull request status:
In case it's "ready for review", I've changed it from "draft" to "non-draft".
I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Description
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist