-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adds opensea to blockaid migration BannerAlert #23743
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
c9ca6fb
to
075befa
Compare
32e3443
to
8bd6b68
Compare
Builds ready [299652a]
Page Load Metrics (1194 ± 562 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #23743 +/- ##
===========================================
- Coverage 69.20% 69.17% -0.03%
===========================================
Files 1160 1160
Lines 44182 44252 +70
Branches 11814 11832 +18
===========================================
+ Hits 30573 30610 +37
- Misses 13609 13642 +33 ☔ View full report in Codecov by Sentry. |
Description
This adds a notice to transaction and signature confirmations for users who have been automatically migrated from the security alerts by Open Sea to security alerts by Blockaid (see #23460) and are on networks that are not supported by Blockaid. The notice can be dismissed and is not shown again once that happens.
The PR adds e2e tests to verify the change for simple send, token approval, personal signature, and contract interaction.
We intend to remove this notice after a few releases.
Related issues
Fixes: #2134
Related: #23546 and #23460
Manual testing steps
112b155d59
)Screenshots/Recordings
After
Simple Send
Token Approval
Personal Signature
Contract Interaction
Pre-merge author checklist
Pre-merge reviewer checklist