-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: change in security settings - removing opensea provider and design changes #23546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpuri
added
team-confirmations-secure-ux-PR
PRs from the confirmations team
needs-dev-review
PR needs reviews from other engineers (in order to receive required approvals)
labels
Mar 18, 2024
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #23546 +/- ##
===========================================
- Coverage 68.44% 68.44% -0.01%
===========================================
Files 1141 1141
Lines 43770 43758 -12
Branches 11729 11727 -2
===========================================
- Hits 29958 29946 -12
Misses 13812 13812 ☔ View full report in Codecov by Sentry. |
… security_settings
…nsion into security_settings
Builds ready [3413861]
Page Load Metrics (1172 ± 432 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Builds ready [8038d04]
Page Load Metrics (995 ± 492 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
pedronfigueiredo
approved these changes
Mar 19, 2024
segun
approved these changes
Mar 19, 2024
github-actions
bot
removed
the
needs-dev-review
PR needs reviews from other engineers (in order to receive required approvals)
label
Mar 19, 2024
metamaskbot
added
the
release-11.14.0
Issue or pull request that will be included in release 11.14.0
label
Mar 19, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-11.14.0
Issue or pull request that will be included in release 11.14.0
team-confirmations-secure-ux-PR
PRs from the confirmations team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removing opensea security provider from settings and change in UI / designs.
Related issues
Fixes: MetaMask/MetaMask-planning#2135
Manual testing steps
Screenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist