Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip simulation metrics if simulation disabled or chain not supported #23713

Merged

Conversation

matthewwalsh0
Copy link
Member

@matthewwalsh0 matthewwalsh0 commented Mar 25, 2024

Description

Skip simulation metrics if simulation is disabled or the transaction chain does not support simulation.

Also adopt breaking changes from the TransactionController that replace the isReverted property with suitable error codes provided by the new SimulationErrorCode enum.

Open in GitHub Codespaces

Related issues

Fixes: #2297

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@matthewwalsh0 matthewwalsh0 added the team-confirmations-system DEPRECATED: please use "team-confirmations" label instead label Mar 25, 2024
@matthewwalsh0 matthewwalsh0 requested a review from a team as a code owner March 25, 2024 21:38
Enable simulation E2E tests.
@matthewwalsh0 matthewwalsh0 requested review from a team as code owners March 27, 2024 21:09
@matthewwalsh0
Copy link
Member Author

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

Policies updated

@matthewwalsh0 matthewwalsh0 requested review from a team as code owners March 28, 2024 09:55
OGPoyraz
OGPoyraz previously approved these changes Mar 28, 2024
…d' of github.com:MetaMask/metamask-extension into fix/skip-simulation-metrics-disabled-chain-not-supported
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 94.73684% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 69.13%. Comparing base (b7dc2bf) to head (c5d4af0).
Report is 2 commits behind head on develop.

Files Patch % Lines
...mponents/simulation-details/simulation-details.tsx 93.33% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #23713   +/-   ##
========================================
  Coverage    69.13%   69.13%           
========================================
  Files         1160     1160           
  Lines        44260    44265    +5     
  Branches     11839    11839           
========================================
+ Hits         30596    30600    +4     
- Misses       13664    13665    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [c5d4af0]
Page Load Metrics (508 ± 403 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint761731162613
domContentLoaded116827136
load632588508839403
domInteractive116827136
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 667 Bytes (0.01%)
  • common: 32.23 KiB (0.65%)

@matthewwalsh0 matthewwalsh0 merged commit b2d843f into develop Mar 28, 2024
66 checks passed
@matthewwalsh0 matthewwalsh0 deleted the fix/skip-simulation-metrics-disabled-chain-not-supported branch March 28, 2024 12:01
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2024
@metamaskbot metamaskbot added the release-11.15.0 Issue or pull request that will be included in release 11.15.0 label Mar 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.15.0 Issue or pull request that will be included in release 11.15.0 team-confirmations-system DEPRECATED: please use "team-confirmations" label instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants