-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: skip simulation metrics if simulation disabled or chain not supported #23713
Merged
matthewwalsh0
merged 10 commits into
develop
from
fix/skip-simulation-metrics-disabled-chain-not-supported
Mar 28, 2024
Merged
fix: skip simulation metrics if simulation disabled or chain not supported #23713
matthewwalsh0
merged 10 commits into
develop
from
fix/skip-simulation-metrics-disabled-chain-not-supported
Mar 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewwalsh0
added
the
team-confirmations-system
DEPRECATED: please use "team-confirmations" label instead
label
Mar 25, 2024
Enable simulation E2E tests.
dbrans
reviewed
Mar 26, 2024
ui/pages/confirmations/components/simulation-details/simulation-details.tsx
Show resolved
Hide resolved
ui/pages/confirmations/components/simulation-details/useSimulationMetrics.ts
Outdated
Show resolved
Hide resolved
ui/pages/confirmations/components/simulation-details/simulation-details.tsx
Show resolved
Hide resolved
dbrans
previously approved these changes
Mar 28, 2024
ui/pages/confirmations/components/simulation-details/simulation-details.tsx
Show resolved
Hide resolved
ui/pages/confirmations/components/simulation-details/simulation-details.tsx
Show resolved
Hide resolved
@metamaskbot update-policies |
Policies updated |
OGPoyraz
previously approved these changes
Mar 28, 2024
…d' of github.com:MetaMask/metamask-extension into fix/skip-simulation-metrics-disabled-chain-not-supported
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #23713 +/- ##
========================================
Coverage 69.13% 69.13%
========================================
Files 1160 1160
Lines 44260 44265 +5
Branches 11839 11839
========================================
+ Hits 30596 30600 +4
- Misses 13664 13665 +1 ☔ View full report in Codecov by Sentry. |
Builds ready [c5d4af0]
Page Load Metrics (508 ± 403 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
OGPoyraz
approved these changes
Mar 28, 2024
dbrans
approved these changes
Mar 28, 2024
ui/pages/confirmations/components/simulation-details/simulation-details.tsx
Show resolved
Hide resolved
ui/pages/confirmations/components/simulation-details/useSimulationMetrics.ts
Show resolved
Hide resolved
matthewwalsh0
deleted the
fix/skip-simulation-metrics-disabled-chain-not-supported
branch
March 28, 2024 12:01
metamaskbot
added
the
release-11.15.0
Issue or pull request that will be included in release 11.15.0
label
Mar 28, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-11.15.0
Issue or pull request that will be included in release 11.15.0
team-confirmations-system
DEPRECATED: please use "team-confirmations" label instead
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Skip simulation metrics if simulation is disabled or the transaction chain does not support simulation.
Also adopt breaking changes from the
TransactionController
that replace theisReverted
property with suitable error codes provided by the newSimulationErrorCode
enum.Related issues
Fixes: #2297
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist