Fix E2E tests

MetaMask · Mar 28, 2024 · c5d4af0 · c5d4af0
1 parent 89c2996
commit c5d4af0
Showing 1 changed file with 15 additions and 11 deletions.
diff --git a/ui/pages/confirmations/components/simulation-details/useSimulationMetrics.ts b/ui/pages/confirmations/components/simulation-details/useSimulationMetrics.ts
@@ -80,16 +80,6 @@ export function useSimulationMetrics({
 
   useIncompleteAssetEvent(balanceChanges, displayNamesByAddress);
 
-  // Skip metrics if simulation disabled or chain not supported.
-  if (
-    [
-      SimulationErrorCode.ChainNotSupported,
-      SimulationErrorCode.Disabled,
-    ].includes(simulationData?.error?.code as SimulationErrorCode)
-  ) {
-    return;
-  }
-
   const receivingAssets = balanceChanges.filter(
     (change) => !change.amount.isNegative,
   );
@@ -123,9 +113,23 @@ export function useSimulationMetrics({
 
   const params = { properties, sensitiveProperties };
 
+  const shouldSkipMetrics = [
+    SimulationErrorCode.ChainNotSupported,
+    SimulationErrorCode.Disabled,
+  ].includes(simulationData?.error?.code as SimulationErrorCode);
+
   useEffect(() => {
+    if (shouldSkipMetrics) {
+      return;
+    }
+
     updateTransactionEventFragment(params, transactionId);
-  }, [transactionId, JSON.stringify(params)]);
+  }, [
+    shouldSkipMetrics,
+    updateTransactionEventFragment,
+    transactionId,
+    JSON.stringify(params),
+  ]);
 }
 
 function useIncompleteAssetEvent(