Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: PPOMController update to fix issue of stale_diff file not found #23654

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Mar 22, 2024

Description

Fixes issue with stale_diff file not found during blockaid validations.

Related issues

Fixes: #23174
Fixes: #23295

Manual testing steps

NA

Screenshots/Recordings

NA

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added team-confirmations-secure-ux-PR PRs from the confirmations team needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Mar 22, 2024
@jpuri jpuri requested a review from a team as a code owner March 22, 2024 17:01
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jpuri jpuri changed the title PPOMController update to fix issue of stale_diff file not found fix: PPOMController update to fix issue of stale_diff file not found Mar 22, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [b8b5b15]
Page Load Metrics (1016 ± 481 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint853651627134
domContentLoaded14120432814
load71238510161002481
domInteractive14120432814
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -149 Bytes (-0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@jpuri jpuri merged commit fc0e886 into develop Mar 25, 2024
73 of 75 checks passed
@jpuri jpuri deleted the ppom_controller_update_0.29.0 branch March 25, 2024 13:02
@github-actions github-actions bot locked and limited conversation to collaborators Mar 25, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 25, 2024
@metamaskbot metamaskbot added release-11.14.1 Issue or pull request that will be included in release 11.14.1 release-11.14.0 Issue or pull request that will be included in release 11.14.0 and removed release-11.14.1 Issue or pull request that will be included in release 11.14.1 labels Mar 25, 2024
@metamaskbot
Copy link
Collaborator

Missing release label release-11.14.0 on PR. Adding release label release-11.14.0 on PR and removing other release labels(release-11.14.1), as PR was added to branch 11.14.0 when release was cut.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.14.0 Issue or pull request that will be included in release 11.14.0 team-confirmations-secure-ux-PR PRs from the confirmations team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Sentry] Error: missing config file [Sentry] PPOM - Error: missing stale_diff file
4 participants