Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sentry] PPOM - Error: missing stale_diff file #23174

Closed
sentry-io bot opened this issue Feb 26, 2024 · 7 comments · Fixed by MetaMask/ppom-validator#178 or #23654
Closed

[Sentry] PPOM - Error: missing stale_diff file #23174

sentry-io bot opened this issue Feb 26, 2024 · 7 comments · Fixed by MetaMask/ppom-validator#178 or #23654
Assignees
Labels
area-Sentry error reporting to sentry regression-prod-11.10.0 Regression bug that was found in production in release 11.10.0 regression-prod-11.13.1 Regression bug that was found in production in release 11.13.1 release-11.14.0 Issue or pull request that will be included in release 11.14.0 release-11.14.1 Issue or pull request that will be included in release 11.14.1 Sev2-normal Normal severity; minor loss of service or inconvenience. team-confirmations Push issues to confirmations team team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead type-bug

Comments

@sentry-io
Copy link

sentry-io bot commented Feb 26, 2024

Sentry Issue: METAMASK-X8ZZ

Error: missing stale_diff file
  at imports.wbg.__wbindgen_error_new (app/scripts/lib/ppom/ppom.js:443:21)
  at None (/metamask/ppom_bg.wasm:wasm-function[51]:0x46de9)
  at None (/metamask/ppom_bg.wasm:wasm-function[1214]:0x199f16)
  at None (/metamask/ppom_bg.wasm:wasm-function[4938]:0x22c1bc)
  at __wbg_adapter_20 (app/scripts/lib/ppom/ppom.js:212:9)
...
(1 additional frame(s) were not displayed)

Comment: Issue occurs in ppom.js file, maybe related to Confirmations?

@gauthierpetetin gauthierpetetin added team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead team-confirmations-system DEPRECATED: please use "team-confirmations" label instead team-confirmations-planning (only for internal use within Confirmations team) Sev2-normal Normal severity; minor loss of service or inconvenience. labels Feb 26, 2024
@seaona seaona changed the title Error: missing stale_diff file [Sentry] PPOM - Error: missing stale_diff file Feb 27, 2024
@cryptotavares cryptotavares removed the team-confirmations-system DEPRECATED: please use "team-confirmations" label instead label Feb 27, 2024
@metamaskbot metamaskbot added type-bug area-Sentry error reporting to sentry regression-prod-11.10.0 Regression bug that was found in production in release 11.10.0 labels Feb 27, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Feb 27, 2024
@bschorchit bschorchit removed the team-confirmations-planning (only for internal use within Confirmations team) label Mar 7, 2024
@segun segun assigned segun and jpuri Mar 7, 2024
@jpuri
Copy link
Contributor

jpuri commented Mar 13, 2024

This is the suspected commit that introduced the issue: #21436

Also, I see that frequency of this error has considerably reduced in recent days. Events on 12th March was only 2.

@seaona
Copy link
Contributor

seaona commented Mar 15, 2024

I've just encountered this issue and cannot recover from this state. The same I was seeing with #23295:

  • Once there's this issue, validations don't work
  • If I disable and enable Blockaid, still does not make it work
  • No cdn requests happen, to try to fetch the files

Hint: I disabled the wallet and enabled it (as I was using another wallet instance). Then I switch to Avalanche and right after tried to perform a malicious tx from the test dapp

missing-stale-diff.mp4

@seaona
Copy link
Contributor

seaona commented Mar 20, 2024

ℹ️ Encountered this again in 11.13

  1. Select Optimism
  2. Trigger a tx from the test dapp --> validations work
  3. Select Mainnet
  4. Trigger a tx from the test dapp --> validations stop working on Mainnet and I got the above error

Screenshot from 2024-03-20 09-32-46

@seaona seaona mentioned this issue Mar 20, 2024
13 tasks
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by severity Mar 22, 2024
@jpuri jpuri reopened this Mar 22, 2024
@github-project-automation github-project-automation bot moved this from Fixed to To be fixed in Bugs by severity Mar 22, 2024
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by severity Mar 25, 2024
@metamaskbot metamaskbot added the release-11.14.1 Issue or pull request that will be included in release 11.14.1 label Mar 25, 2024
@metamaskbot metamaskbot added the release-11.14.0 Issue or pull request that will be included in release 11.14.0 label Mar 26, 2024
@metamaskbot
Copy link
Collaborator

Missing release label release-11.14.0 on issue. Adding release label release-11.14.0 on issue, as issue is linked to PR #23654 which has this release label.

Copy link
Author

sentry-io bot commented Apr 4, 2024

Sentry Issue: METAMASK-X9MC

Copy link
Author

sentry-io bot commented Apr 4, 2024

Sentry Issue: METAMASK-X9MB

@metamaskbot metamaskbot added the regression-prod-11.13.1 Regression bug that was found in production in release 11.13.1 label Apr 4, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team Apr 4, 2024
@gauthierpetetin gauthierpetetin moved this from To be fixed to Fixed in Bugs by team Apr 4, 2024
@seaona
Copy link
Contributor

seaona commented Apr 25, 2024

re-opening as this issue is still present, related to the CDN

@seaona seaona reopened this Apr 25, 2024
@github-project-automation github-project-automation bot moved this from Fixed to To be fixed in Bugs by severity Apr 25, 2024
@jpuri jpuri closed this as completed Apr 27, 2024
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by severity Apr 27, 2024
@gauthierpetetin gauthierpetetin added the team-confirmations Push issues to confirmations team label Apr 30, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Sentry error reporting to sentry regression-prod-11.10.0 Regression bug that was found in production in release 11.10.0 regression-prod-11.13.1 Regression bug that was found in production in release 11.13.1 release-11.14.0 Issue or pull request that will be included in release 11.14.0 release-11.14.1 Issue or pull request that will be included in release 11.14.1 Sev2-normal Normal severity; minor loss of service or inconvenience. team-confirmations Push issues to confirmations team team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead type-bug
Projects
Archived in project
7 participants