Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MMI - updates snapshots #23128

Merged
merged 3 commits into from
Feb 23, 2024
Merged

MMI - updates snapshots #23128

merged 3 commits into from
Feb 23, 2024

Conversation

zone-live
Copy link
Contributor

@zone-live zone-live commented Feb 22, 2024

Description

Updates MMI visual Snapshots.

Can be checked in GH "Files changed" tab -> Swipe view option and drag

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@zone-live zone-live added the team-mmi PRs from the MMI team label Feb 22, 2024
@zone-live zone-live requested a review from a team as a code owner February 22, 2024 17:42
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [1d9dce6]
Page Load Metrics (1910 ± 90 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint813671746330
domContentLoaded107730199
load15872255191018890
domInteractive107730199
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.48%. Comparing base (275523a) to head (ac9262d).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #23128   +/-   ##
========================================
  Coverage    68.48%   68.48%           
========================================
  Files         1090     1090           
  Lines        43155    43155           
  Branches     11506    11506           
========================================
  Hits         29551    29551           
  Misses       13604    13604           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [3e4472d]
Page Load Metrics (1805 ± 83 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1104351878340
domContentLoaded999332512
load15562390180517383
domInteractive999332512
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [ac9262d]
Page Load Metrics (1796 ± 55 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1204311817033
domContentLoaded117629199
load16191974179611455
domInteractive117629199
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@DDDDDanica
Copy link
Contributor

LGTM !

@zone-live zone-live merged commit e86995e into develop Feb 23, 2024
66 checks passed
@zone-live zone-live deleted the MMI-snapshots-fix branch February 23, 2024 11:34
@github-actions github-actions bot locked and limited conversation to collaborators Feb 23, 2024
@metamaskbot metamaskbot added the release-11.13.0 Issue or pull request that will be included in release 11.13.0 label Feb 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.13.0 Issue or pull request that will be included in release 11.13.0 team-mmi PRs from the MMI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants