-
Notifications
You must be signed in to change notification settings - Fork 5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge branch 'develop' into MMI-snapshots-fix
- Loading branch information
Showing
32 changed files
with
400 additions
and
421 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| name: Validate Conventional Commit Title | ||
| on: | ||
| pull_request: | ||
| types: [opened, edited, reopened] | ||
|
|
||
| jobs: | ||
| pr-title-linter: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| # this is a hash for amannn/[email protected] | ||
| - uses: amannn/action-semantic-pull-request@c3cd5d1ea3580753008872425915e343e351ab54 | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,91 @@ | ||
| import { | ||
| KnownOrigins, | ||
| OffscreenCommunicationTarget, | ||
| } from '../../shared/constants/offscreen-communication'; | ||
|
|
||
| async function openConnectorTab(url: string) { | ||
| const browserTab = window.open(url); | ||
| if (!browserTab) { | ||
| throw new Error('Failed to open Lattice connector.'); | ||
| } | ||
|
|
||
| return browserTab; | ||
| } | ||
|
|
||
| export default function init() { | ||
| /** | ||
| * The main element of the eth-lattice-keyring library that is impacted by MV3 | ||
| * is the _openConnectorTab method which is responsible for opening a tab to | ||
| * the lattice connector. This method is called by the _getCreds method of the | ||
| * keyring. In the default keyring this would be attempted inside the service | ||
| * worker which has no DOM and therefore would fail. The solution is to split | ||
| * the functionality so that the openConnectorTab portion operates inside the | ||
| * offscreen document with its DOM. That is what this file is responsible for. | ||
| * | ||
| * When receiving a message from the service worker script targeting the | ||
| * lattice iframe, this listener will execute and open the new tab for | ||
| * connecting to the lattice device. The response from the lattice connector | ||
| * is then sent back to the offscreen bridge for lattice, which extends from | ||
| * the eth-lattice-keyring Keyring class. | ||
| */ | ||
| chrome.runtime.onMessage.addListener((msg, _sender, sendResponse) => { | ||
| if (msg.target !== OffscreenCommunicationTarget.latticeOffscreen) { | ||
| return; | ||
| } | ||
|
|
||
| // Open the tab | ||
| openConnectorTab(msg.params.url).then((browserTab) => { | ||
| // Watch for the open window closing before creds are sent back | ||
| const listenInterval = setInterval(() => { | ||
| if (browserTab.closed) { | ||
| clearInterval(listenInterval); | ||
| sendResponse({ | ||
| error: new Error('Lattice connector closed.'), | ||
| }); | ||
| } | ||
| }, 500); | ||
|
|
||
| // On a Chromium browser we can just listen for a window message from the | ||
| // lattice tab (using the event.origin property). When we get that it'll be | ||
| // the response from the lattice connector with the deviceID and password. | ||
| // We can then forward that response to the lattice-offscreen-keyring's | ||
| // _getCreds method using sendResponse API from the chrome runtime. | ||
| window.addEventListener( | ||
| 'message', | ||
| (event) => { | ||
| // Ensure origin | ||
| if ( | ||
| event.origin !== KnownOrigins.lattice && | ||
| event.source === browserTab | ||
| ) { | ||
| return; | ||
| } | ||
|
|
||
| try { | ||
| // Stop the listener | ||
| clearInterval(listenInterval); | ||
|
|
||
| // Parse and return creds | ||
| const creds = JSON.parse(event.data); | ||
| if (!creds.deviceID || !creds.password) { | ||
| sendResponse({ | ||
| error: new Error('Invalid credentials returned from Lattice.'), | ||
| }); | ||
| } | ||
| sendResponse({ | ||
| result: creds, | ||
| }); | ||
| } catch (err) { | ||
| sendResponse({ | ||
| error: err, | ||
| }); | ||
| } | ||
| }, | ||
| false, | ||
| ); | ||
| }); | ||
|
|
||
| // eslint-disable-next-line consistent-return | ||
| return true; | ||
| }); | ||
| } |
Oops, something went wrong.