Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lock Timer #2297

Closed
wants to merge 3 commits into from
Closed

Lock Timer #2297

wants to merge 3 commits into from

Conversation

2-am-zzz
Copy link
Contributor

@2-am-zzz 2-am-zzz commented Oct 6, 2017

Still in MVP, solves #39. Would be better to establish:

  • Formal time for locking.
  • Option to disable/enable this feature in config.
  • UI notification on the fox logo to note that locking has occurred.

@danfinlay
Copy link
Contributor

Tests aren't passing. What do "For Fun" and "in MVP" mean? Is this a serious PR? Should I take the time to review this?

@2-am-zzz 2-am-zzz changed the title Lock Timer (For Fun) Lock Timer Oct 9, 2017
@2-am-zzz 2-am-zzz added the DO-NOT-MERGE Pull requests that should not be merged label Oct 9, 2017
@2-am-zzz
Copy link
Contributor Author

2-am-zzz commented Oct 9, 2017

It's a serious PR, but DNM for now.

@2-am-zzz 2-am-zzz closed this Oct 17, 2017
@dsldsl
Copy link

dsldsl commented Dec 11, 2017

Is there an update on this? major security importance, along with #39 and #1604 which both closed pointing here.

@danfinlay
Copy link
Contributor

Oh, those should not have been closed if they relied on this for them. Reopening one.

@danfinlay
Copy link
Contributor

#39 is still open, and will represent this.

@dsldsl
Copy link

dsldsl commented Dec 12, 2017

Got it, thank you.

@2-am-zzz 2-am-zzz deleted the locktimer branch January 5, 2018 23:19
danjm pushed a commit that referenced this pull request Apr 9, 2024
@matthewwalsh0 @metamaskbot
cherry-pick: skip simulation metrics if simulation disabled or chain …
1807f80 
…not supported (#23713) (#23882)

Cherry-pick of PR #23713 for issue
[#2297](MetaMask/MetaMask-planning#2297).

Conflicts in package versions and Lavamoat policy files.

---------

Co-authored-by: MetaMask Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
DO-NOT-MERGE Pull requests that should not be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@2-am-zzz @danfinlay @dsldsl