Revert "Updated copy changes for display NFT Media (#20380)"

[danjm]

This reverts commit 6c1b71b.

Description

This is a temporary fix to https://github.com/MetaMask/MetaMask-planning/issues/1380

The changes needed to justify the copy update in #20380 have not been made yet. See this comment for more details

We will make future fixes to the nft-controller to justify the copy changes that are being reverted here. After that, we can revert this revert.

Manual testing steps

In the "Security and Privacy" tab of settings, we should see a toggle with "Enable OpenSea API" as the label and "Use OpenSea's API to fetch NFT data. NFT auto-detection relies on OpenSea's API, and will not be available when this is turned off." as the description.

We should be able to search in settings for that toggle.

Switch to french, spanish and chinese languages, and the expected translations of the above copy should be present.

When the toggle is off, already imported NFTs from opensea should display no image. Also, when the toggle is off, you should not be able to click "Refresh List" to detect NFTs.

However, note that if the toggle is off and you manually import NFTs whose token metadata is stored on a server, a network request is still made to that server, and if the image of that NFT is stored on IPFS, it will be displayed. (This is what we will change in the future, before reverting this revert.

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change.

After

Before

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've clearly explained:
  • What problem this PR is solving.
  • How this problem was solved.
  • How reviewers can test my changes.
• I’ve indicated what issue this PR is linked to: Fixes #???
• I’ve included tests if applicable.
• I’ve documented any added code.
• I’ve applied the right labels on the PR (see labeling guidelines).
• I’ve properly set the pull request status:
  • In case it's not yet "ready for review", I've set it to "draft".
  • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [a8672b3]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4
  • common: 0, 1, 2, 3, 4, 5, 6
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • inpage: inpage
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1015 ± 362 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	85	122	99	10	5
		domContentLoaded	72	118	92	11	5
		load	87	1937	1015	755	362
		domInteractive	72	118	92	11	5

Bundle size diffs [🚀 Bundle size reduced!]

• background: 0 Bytes (0.00%)
• ui: 18 Bytes (0.00%)
• common: -138 Bytes (-0.00%)

[codecov]

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (b4aff28) 68.46% compared to head (c8363f7) 68.46%.
Report is 1 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #21109   +/-   ##
========================================
  Coverage    68.46%   68.46%           
========================================
  Files         1012     1012           
  Lines        40447    40447           
  Branches     10790    10790           
========================================
  Hits         27692    27692           
  Misses       12755    12755           

Files	Coverage Δ
...e-import-nfts/nfts-detection-notice-import-nfts.js	0.00% <ø> (ø)
...es/settings/security-tab/security-tab.component.js	100.00% <ø> (ø)
ui/helpers/constants/settings.js	33.77% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[metamaskbot]

Builds ready [c8363f7]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4
  • common: 0, 1, 2, 3, 4, 5, 6, 7
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • inpage: inpage
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (977 ± 384 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	86	141	109	17	8
		domContentLoaded	73	142	102	21	10
		load	87	2141	977	799	384
		domInteractive	73	142	102	21	10

Bundle size diffs [🚀 Bundle size reduced!]

• background: 0 Bytes (0.00%)
• ui: 22 Bytes (0.00%)
• common: -118 Bytes (-0.00%)