Updated copy changes for display NFT Media (#20380)

* updated copy changes * updated snapshots * lint fix * updated test
MetaMask · Aug 3, 2023 · 6c1b71b · 6c1b71b
1 parent 23ea1a6
commit 6c1b71b
Show file tree

Hide file tree

Showing 22 changed files with 20 additions and 116 deletions.
diff --git a/app/_locales/de/messages.json b/app/_locales/de/messages.json
diff --git a/app/_locales/el/messages.json b/app/_locales/el/messages.json
diff --git a/app/_locales/en/messages.json b/app/_locales/en/messages.json
diff --git a/app/_locales/es/messages.json b/app/_locales/es/messages.json
diff --git a/app/_locales/es_419/messages.json b/app/_locales/es_419/messages.json
diff --git a/app/_locales/fr/messages.json b/app/_locales/fr/messages.json
diff --git a/app/_locales/hi/messages.json b/app/_locales/hi/messages.json
diff --git a/app/_locales/id/messages.json b/app/_locales/id/messages.json
diff --git a/app/_locales/ja/messages.json b/app/_locales/ja/messages.json
diff --git a/app/_locales/ko/messages.json b/app/_locales/ko/messages.json
diff --git a/app/_locales/pt/messages.json b/app/_locales/pt/messages.json
diff --git a/app/_locales/pt_BR/messages.json b/app/_locales/pt_BR/messages.json
diff --git a/app/_locales/ru/messages.json b/app/_locales/ru/messages.json
diff --git a/app/_locales/tl/messages.json b/app/_locales/tl/messages.json
diff --git a/app/_locales/tr/messages.json b/app/_locales/tr/messages.json
diff --git a/app/_locales/vi/messages.json b/app/_locales/vi/messages.json
diff --git a/app/_locales/zh_CN/messages.json b/app/_locales/zh_CN/messages.json
diff --git a/ui/helpers/constants/settings.js b/ui/helpers/constants/settings.js
@@ -215,8 +215,8 @@ export const SETTINGS_CONSTANTS = [
   },
   {
     tabMessage: (t) => t('securityAndPrivacy'),
-    sectionMessage: (t) => t('enableOpenSeaAPI'),
-    descriptionMessage: (t) => t('enableOpenSeaAPIDescription'),
+    sectionMessage: (t) => t('displayNftMedia'),
+    descriptionMessage: (t) => t('displayNftMediaDescription'),
     route: `${SECURITY_ROUTE}#opensea-api`,
     icon: 'fa fa-lock',
   },

diff --git a/ui/helpers/utils/settings-search.test.js b/ui/helpers/utils/settings-search.test.js
@@ -103,10 +103,10 @@ const t = (key) => {
       return 'Autodetect tokens';
     case 'autoDetectTokensDescription':
       return 'We use third-party APIs to detect and display new tokens sent to your wallet. Turn off if you don’t want the app to pull data from those services.';
-    case 'enableOpenSeaAPI':
-      return 'Enable OpenSea API';
-    case 'enableOpenSeaAPIDescription':
-      return "Use OpenSea's API to fetch NFT data. NFT auto-detection relies on OpenSea's API, and will not be available when this is turned off.";
+    case 'displayNftMedia':
+      return 'Display NFT media';
+    case 'displayNftMediaDescription':
+      return "Displaying NFT media and data exposes your IP address to OpenSea or other third parties. This can allow attackers to associate your IP address with your Ethereum address. NFT autodetection relies on this setting, and won't be available when this is turned off.";
     case 'useNftDetection':
       return 'Autodetect NFTs';
     case 'useNftDetectionDescription':

diff --git a/ui/pages/settings/security-tab/__snapshots__/security-tab.test.js.snap b/ui/pages/settings/security-tab/__snapshots__/security-tab.test.js.snap
@@ -721,20 +721,20 @@ exports[`Security Tab should match snapshot 1`] = `
           class="settings-page__content-item"
         >
           <span>
-            Enable OpenSea API
+            Display NFT media
           </span>
           <div
             class="settings-page__content-description"
           >
-            Use OpenSea's API to fetch NFT data. NFT auto-detection relies on OpenSea's API, and will not be available when this is turned off.
+            Displaying NFT media and data exposes your IP address to OpenSea or other third parties. This can allow attackers to associate your IP address with your Ethereum address. NFT autodetection relies on this setting, and won't be available when this is turned off.
           </div>
         </div>
         <div
           class="settings-page__content-item"
         >
           <div
             class="settings-page__content-item-col"
-            data-testid="enableOpenSeaAPI"
+            data-testid="displayNftMedia"
           >
             <label
               class="toggle-button toggle-button--off"

diff --git a/ui/pages/settings/security-tab/security-tab.component.js b/ui/pages/settings/security-tab/security-tab.component.js
@@ -619,15 +619,15 @@ export default class SecurityTab extends PureComponent {
     return (
       <div ref={this.settingsRefs[10]} className="settings-page__content-row">
         <div className="settings-page__content-item">
-          <span>{t('enableOpenSeaAPI')}</span>
+          <span>{t('displayNftMedia')}</span>
           <div className="settings-page__content-description">
-            {t('enableOpenSeaAPIDescription')}
+            {t('displayNftMediaDescription')}
           </div>
         </div>
         <div className="settings-page__content-item">
           <div
             className="settings-page__content-item-col"
-            data-testid="enableOpenSeaAPI"
+            data-testid="displayNftMedia"
           >
             <ToggleButton
               value={openSeaEnabled}

diff --git a/ui/pages/settings/security-tab/security-tab.test.js b/ui/pages/settings/security-tab/security-tab.test.js
@@ -46,8 +46,8 @@ describe('Security Tab', () => {
     expect(container).toMatchSnapshot();
   });
 
-  it('toggles opensea api enabled', async () => {
-    expect(await toggleCheckbox('enableOpenSeaAPI', false)).toBe(true);
+  it('toggles Display NFT media enabled', async () => {
+    expect(await toggleCheckbox('displayNftMedia', false)).toBe(true);
   });
 
   it('toggles nft detection', async () => {