Master sync following v11.1.0 #21075

danjm · 2023-09-27T15:20:32Z

No description provided.

…ttons (#20767) * shows MMI buttons and hides the Buy and Bridge buttons * minor update

* allow NFTs content view * prettier * Update app/_locales/en/messages.json Co-authored-by: Nidhi Kumari <[email protected]> --------- Co-authored-by: Nidhi Kumari <[email protected]>

Deleting line "The recipient's hexadecimal address is shown in the activity list item." as the hexadecimal address is not supposed to be shown in the activity list item unless you open the activity list item, in the next step.

…0807)

…0748) I made a mistake in a suggestion on PR #20168, and Mark Stacey noticed it. This PR fixes it.

* Skip first character in snap name if it is a @ * Simplify implementation

* Update `useScrollRequired` to only require to scroll to bottom one time * remove console.log * simplify logic * add comment about magic number

The `metamaskbot` comment on each PR now includes links to MMI builds. This relates to #20782

MMI builds are now published alongside stable releases, in the same manner as Flask. They will be included in future GitHub release pages, and tracked using separate git tags. Sentry sourcemaps are uploaded for them during the release process as well. Closes #20782

* Bump LavaMoat and SES * Use latest versions * Use [email protected] * Update LavaMoat policies * Unpin LavaMoat versions * update lavamoat build policy * Fix LavaMoat patch * Update LavaMoat policies --------- Co-authored-by: Frederik Bolding <[email protected]> Co-authored-by: MetaMask Bot <[email protected]> Co-authored-by: legobt <[email protected]>

* Fix #20910 - Turn off ENS resolution if IPFS is turned off * Updated WIP * Implement conditions for ENS and IPFS settings * Remove initial fix * Fix e2es

* updated placeholder for erc-1155 image * removed code duplication * updated collections * updated snapshot * updated stories * updated condition from includes to startsWith * Use startsWith instead of includes --------- Co-authored-by: Danica Shen <[email protected]> Co-authored-by: David Walsh <[email protected]> Co-authored-by: chloeYue <[email protected]>

* Fix copy and add 3rd party API links * Extract uppercase logic into a variable * Fix snapshot tests * fix e2e test * fix lint error

…ts on the same client (#20973) * fix incoming tx filtering * tweak filtering * tweak filtering * tweak filtering * tweak filtering * refactor filtering on activity list * simplify solution * update comment * reintroduce filtering and address comments * fix linting errors * fix test * fix comment * wip * wip

This PR is to show the NFT Default image when the Image is hosted on OpenSea but display Media is off Further Context [slack message ](https://consensys.slack.com/archives/C029JG63136/p1695634003818569?thread_ts=1693992718.193729&cid=C029JG63136) 1. When IPFS is enabled: - If NFT image relies on IPFS storage show the NFT - If NFT image relies on OpenSea and OpenSea toggle is ON, show NFT - If NFT image relies on OpenSea and OpenSea toggle is OFF, show Default Image without the show Button. - If both the toggles are on, show NFT 2. When IPFS is disabled: - If the NFT image relies on IPFS storage, show Default Image with the show Button. - If the NFT image relies on OpenSea and OpenSea toggle is ON, show NFT - If the NFT image relies on OpenSea and OpenSea toggle is OFF, show Default Image without the show Button _Fixes [https://github.com/MetaMask/MetaMask-planning/issues/1330](#https://github.com/MetaMask/MetaMask-planning/issues/1330) - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've clearly explained: - [x] What problem this PR is solving. - [x] How this problem was solved. - [x] How reviewers can test my changes. - [x] I’ve indicated what issue this PR is linked to: Fixes #??? - [ ] I’ve included tests if applicable. - [ ] I’ve documented any added code. - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). - [ ] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: Dan J Miller <[email protected]> Co-authored-by: Brad Decker <[email protected]>

Version v11.1.0 RC

github-actions · 2023-09-27T15:20:45Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Gudahtt

LGTM!

metamaskbot · 2023-09-27T18:10:54Z

Builds ready [413ff9a]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1041 ± 367 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	89	164	116	22	10
		domContentLoaded	73	161	108	24	12
		load	85	1922	1041	765	367
		domInteractive	73	161	108	24	12

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

codecov · 2023-09-27T18:11:00Z

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (89c40cb) 68.38% compared to head (413ff9a) 68.38%.
Report is 4 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #21075   +/-   ##
========================================
  Coverage    68.38%   68.38%           
========================================
  Files         1008     1008           
  Lines        40288    40288           
  Branches     10779    10779           
========================================
  Hits         27548    27548           
  Misses       12740    12740

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

danjm and others added 27 commits September 6, 2023 06:57

v11.1.0

388243c

[MMI] Shows Stake & Portfolio buttons and hides the Buy and Bridge bu…

dd3f2e5

…ttons (#20767) * shows MMI buttons and hides the Buy and Bridge buttons * minor update

[MMI] Show the NFT tab content for mmi (#20830)

591f81c

* allow NFTs content view * prettier * Update app/_locales/en/messages.json Co-authored-by: Nidhi Kumari <[email protected]> --------- Co-authored-by: Nidhi Kumari <[email protected]>

Update send native token origin MM.csv (#20880)

421a7b4

Deleting line "The recipient's hexadecimal address is shown in the activity list item." as the hexadecimal address is not supposed to be shown in the activity list item unless you open the activity list item, in the next step.

Make permissions modal scrollable (#20409)

6edf447

Fix broken approveTokenDescriptionWithoutSymbol translation key (#2…

1a7d373

…0807)

Fix undefined getCurrentNetworkTransactions on speed up (#20899)

ed09d92

fix: "Allow quick Add Account name based on default name" (20168) (#2…

7b1339e

…0748) I made a mistake in a suggestion on PR #20168, and Mark Stacey noticed it. This PR fixes it.

Use first non-symbol character as snap fallback icon (#20851)

658c3a0

* Skip first character in snap name if it is a @ * Simplify implementation

Only show enabled insight snaps on the confirmation screen (#20850)

a848343

Update useScrollRequired logic (#20889)

c4f970a

* Update `useScrollRequired` to only require to scroll to bottom one time * remove console.log * simplify logic * add comment about magic number

Updating ppom validator (#20756)

189a0f5

Adding env vars for blockaid to build file (#20769)

54fda97

Revert ppom.js exactly yo audited version (#20826)

7facdeb

Add MMI builds to metamaskbot comment (#20783)

74970e7

The `metamaskbot` comment on each PR now includes links to MMI builds. This relates to #20782

Fix spacing on connected sites in the snap details page (#20854)

f134493

Fix #20910 - Turn off ENS resolution if IPFS is turned off (#20915)

645af3d

* Fix #20910 - Turn off ENS resolution if IPFS is turned off * Updated WIP * Implement conditions for ENS and IPFS settings * Remove initial fix * Fix e2es

fix: Copy and add 3rd party API links (#20929)

b5626eb

* Fix copy and add 3rd party API links * Extract uppercase logic into a variable * Fix snapshot tests * fix e2e test * fix lint error

fix: Tweak banner copy (#20981)

55dccf2

Update changelog v11.1.0 (#20800)

7b7ab8f

Merge pull request #20752 from MetaMask/Version-v11.1.0

75bd47a

Version v11.1.0 RC

Merge origin/develop into master-sync

413ff9a

danjm requested a review from a team as a code owner September 27, 2023 15:20

Gudahtt approved these changes Sep 27, 2023

View reviewed changes

Gudahtt added the team-extension-platform label Sep 27, 2023

pedronfigueiredo approved these changes Sep 27, 2023

View reviewed changes

danjm merged commit cc2880d into develop Sep 27, 2023
9 of 10 checks passed

danjm deleted the master-sync branch September 27, 2023 18:43

github-actions bot locked and limited conversation to collaborators Sep 27, 2023

metamaskbot added the release-11.3.0 Issue or pull request that will be included in release 11.3.0 label Sep 27, 2023

danjm removed the release-11.3.0 Issue or pull request that will be included in release 11.3.0 label Sep 28, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Master sync following v11.1.0 #21075

Master sync following v11.1.0 #21075

danjm commented Sep 27, 2023

github-actions bot commented Sep 27, 2023

Gudahtt left a comment

metamaskbot commented Sep 27, 2023

codecov bot commented Sep 27, 2023 •

edited

Loading

Master sync following v11.1.0 #21075

Master sync following v11.1.0 #21075

Conversation

danjm commented Sep 27, 2023

github-actions bot commented Sep 27, 2023

Gudahtt left a comment

Choose a reason for hiding this comment

metamaskbot commented Sep 27, 2023

codecov bot commented Sep 27, 2023 • edited Loading

Codecov Report

codecov bot commented Sep 27, 2023 •

edited

Loading