-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Tweak banner copy #20981
Merged
Merged
fix: Tweak banner copy #20981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
danjm
added
release-blocker
This bug is blocking the next release
release-11.1.0
Issue or pull request that will be included in release 11.1.0
labels
Sep 21, 2023
pedronfigueiredo
force-pushed
the
fix/1332-privacy-copy
branch
from
September 21, 2023 12:12
71e5bfa
to
f2532df
Compare
digiwand
reviewed
Sep 21, 2023
digiwand
reviewed
Sep 21, 2023
DDDDDanica
previously approved these changes
Sep 21, 2023
pedronfigueiredo
force-pushed
the
fix/1332-privacy-copy
branch
2 times, most recently
from
September 21, 2023 15:01
d9eb2b8
to
3b5829e
Compare
digiwand
previously approved these changes
Sep 21, 2023
pedronfigueiredo
force-pushed
the
fix/1332-privacy-copy
branch
from
September 21, 2023 16:19
8b2e51b
to
5e82a83
Compare
Ameralameri
approved these changes
Sep 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approv
pedronfigueiredo
force-pushed
the
fix/1332-privacy-copy
branch
from
September 21, 2023 16:46
5e82a83
to
742f78c
Compare
danjm
previously approved these changes
Sep 21, 2023
brad-decker
previously approved these changes
Sep 21, 2023
pedronfigueiredo
force-pushed
the
fix/1332-privacy-copy
branch
7 times, most recently
from
September 22, 2023 15:44
5f5a732
to
0c7f68a
Compare
pedronfigueiredo
dismissed stale reviews from danjm and brad-decker
via
September 22, 2023 17:32
53a7e5d
pedronfigueiredo
force-pushed
the
fix/1332-privacy-copy
branch
from
September 22, 2023 17:35
53a7e5d
to
c9b1fdd
Compare
DDDDDanica
approved these changes
Sep 22, 2023
sahar-fehri
approved these changes
Sep 22, 2023
Co-authored-by: Ariella Vu <[email protected]>
pedronfigueiredo
force-pushed
the
fix/1332-privacy-copy
branch
from
September 22, 2023 18:11
c9b1fdd
to
b2d13e5
Compare
metamaskbot
added
the
release-11.3.0
Issue or pull request that will be included in release 11.3.0
label
Sep 22, 2023
Builds ready [b2d13e5]
Page Load Metrics (1582 ± 29 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
danjm
removed
the
release-11.3.0
Issue or pull request that will be included in release 11.3.0
label
Sep 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-11.1.0
Issue or pull request that will be included in release 11.1.0
release-blocker
This bug is blocking the next release
team-extension-platform
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Copy fixes
Related issues
Fixes 1332
Manual testing steps
Pre-merge author checklist
Pre-merge reviewer checklist