Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Tweak banner copy #20981

Merged
merged 12 commits into from
Sep 22, 2023
Merged

fix: Tweak banner copy #20981

merged 12 commits into from
Sep 22, 2023

Conversation

pedronfigueiredo
Copy link
Contributor

@pedronfigueiredo pedronfigueiredo commented Sep 21, 2023

Description

Copy fixes

Related issues

Fixes 1332

Manual testing steps

  • Onboarding flow > advanced privacy settings > Show ENS domains in the address bar
  • On mainnet > open NFT Tab
  • On mainnet > open NFT Tab > "import NFT"
  • Settings > Security & Privacy > Network Provider > Show ENS domains in address bar
  • Settings > Security & Privacy > NFT autodetection
  • Settings > Security & Privacy > display NFT media

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained:
    • What problem this PR is solving.
    • How this problem was solved.
    • How reviewers can test my changes.
  • I’ve indicated what issue this PR is linked to: Fixes #???
  • I’ve included tests if applicable.
  • I’ve documented any added code.
  • I’ve applied the right labels on the PR (see labeling guidelines).
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@danjm danjm added release-blocker This bug is blocking the next release release-11.1.0 Issue or pull request that will be included in release 11.1.0 labels Sep 21, 2023
DDDDDanica
DDDDDanica previously approved these changes Sep 21, 2023
digiwand
digiwand previously approved these changes Sep 21, 2023
Copy link

@Ameralameri Ameralameri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approv

danjm
danjm previously approved these changes Sep 21, 2023
brad-decker
brad-decker previously approved these changes Sep 21, 2023
@pedronfigueiredo pedronfigueiredo force-pushed the fix/1332-privacy-copy branch 7 times, most recently from 5f5a732 to 0c7f68a Compare September 22, 2023 15:44
@pedronfigueiredo pedronfigueiredo dismissed stale reviews from danjm and brad-decker via 53a7e5d September 22, 2023 17:32
@pedronfigueiredo pedronfigueiredo merged commit 62e4f53 into develop Sep 22, 2023
9 checks passed
@pedronfigueiredo pedronfigueiredo deleted the fix/1332-privacy-copy branch September 22, 2023 18:55
@github-actions github-actions bot locked and limited conversation to collaborators Sep 22, 2023
@metamaskbot metamaskbot added the release-11.3.0 Issue or pull request that will be included in release 11.3.0 label Sep 22, 2023
@metamaskbot
Copy link
Collaborator

Builds ready [b2d13e5]
Page Load Metrics (1582 ± 29 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint116172142167
domContentLoaded1469168715826129
load1469168815826129
domInteractive1469168715826129
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: 471 Bytes (0.01%)
  • common: -348 Bytes (-0.01%)

@danjm danjm removed the release-11.3.0 Issue or pull request that will be included in release 11.3.0 label Sep 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.1.0 Issue or pull request that will be included in release 11.1.0 release-blocker This bug is blocking the next release team-extension-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants