Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX: Faster perceived performance of popup #21015

Merged
merged 2 commits into from
Sep 25, 2023

Conversation

darkwing
Copy link
Contributor

Description

With #20843 we made JavaScript for the extension load asynchronously, which helped to get the popup displaying faster. Unfortunately with a timeout of 0 to kick off the process, the popup still acts as though it's blocking (not async). By adding a small timeout, the popup display much faster.

Manual testing steps

  1. On current develop, mentally note how much time it takes for the popup to display
  2. Check out this PR
  3. Restart the extension
  4. See that the popup displays much faster!

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained:
    • What problem this PR is solving.
    • How this problem was solved.
    • How reviewers can test my changes.
  • I’ve indicated what issue this PR is linked to: Fixes #???
  • I’ve included tests if applicable.
  • I’ve documented any added code.
  • I’ve applied the right labels on the PR (see labeling guidelines).
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@darkwing darkwing requested a review from a team as a code owner September 22, 2023 21:14
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@darkwing darkwing added team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead needs-ux-ds-review labels Sep 22, 2023
@metamaskbot
Copy link
Collaborator

Builds ready [30b77da]
Page Load Metrics (696 ± 324 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint8012396126
domContentLoaded6311387178
load741562696675324
domInteractive6311387178
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@codecov
Copy link

codecov bot commented Sep 23, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (315c043) 68.34% compared to head (30b77da) 68.34%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #21015   +/-   ##
========================================
  Coverage    68.34%   68.34%           
========================================
  Files         1007     1007           
  Lines        40254    40254           
  Branches     10761    10761           
========================================
  Hits         27508    27508           
  Misses       12746    12746           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@darkwing darkwing merged commit 8a16141 into develop Sep 25, 2023
9 checks passed
@darkwing darkwing deleted the faster-perceived-performance branch September 25, 2023 17:25
@github-actions github-actions bot locked and limited conversation to collaborators Sep 25, 2023
@metamaskbot metamaskbot added the release-11.3.0 Issue or pull request that will be included in release 11.3.0 label Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.3.0 Issue or pull request that will be included in release 11.3.0 team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants