UX: Load the extension HTML pages and background with async JavaScript #20843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
darkwing
force-pushed
the
async-load-app
branch
from
8b407dc to
46604aa
Compare
darkwing
added
team-extension-ux
darkwing
force-pushed
the
async-load-app
branch
2 times, most recently
from
70358b6 to
ab73693
Compare
darkwing
force-pushed
the
async-load-app
branch
2 times, most recently
from
45b8562 to
ccef0c8
Compare
darkwing
force-pushed
the
async-load-app
branch
3 times, most recently
from
e558a10 to
696c60c
Compare
14 tasks
Builds ready [2554c62]
Page Load Metrics (633 ± 350 ms)
Bundle size diffs
|
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## develop #20843 +/- ##
========================================
Coverage 68.40% 68.40%
========================================
Files 1006 1006
Lines 40218 40218
Branches 10758 10758
========================================
Hits 27508 27508
Misses 12710 12710 ☔ View full report in Codecov by Sentry. |
darkwing
force-pushed
the
async-load-app
branch
from
2554c62 to
9c4f387
Compare
Builds ready [c61c0c8]
Page Load Metrics (1856 ± 72 ms)
Bundle size diffs
|
kumavis
reviewed
Sep 21, 2023
| applyLavaMoat, | ||
| isMMI: buildType === 'mmi', | ||
| }); | ||
| renderJavaScriptLoader({ | ||
| groupSet, | ||
| commonSet, | ||
| browserPlatforms, | ||
| applyLavaMoat, |
There was a problem hiding this comment.
Unfortunately not because of this code in the home.html file:
{{@if(it.isMMI)}}
<title>MetaMask Institutional</title>
{{/if}}
kumavis
approved these changes
Sep 21, 2023
zone-live
approved these changes
Sep 22, 2023
vthomas13
approved these changes
Sep 22, 2023
metamaskbot
added
the
release-11.3.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
At present the loading of both the fullscreen view and MetaMask popup are really slow due to the loading of ~15-20 synchronous JavaScript files in
home.html,popup.html, andnotification.html. Our users experience this slowness most notably when clicking on the MetaMask icon in the extensions toolbar -- the click happens, then nothing for seemingly 1-2 seconds, and then the popup finally renders the user's wallet.This PR loads both the UI and background scripts (1) sequentially and (2) asynchronously, drastically improving perceived performance. Now when clicking the MetaMask extension icon, the popup displays immediately, shows a spinner while the scripts load, and then load in the UI.
Screenshots/Screencaps
FastLoad.mov
Manual Testing Steps
yarn startPre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Boardlabel.In this case, a QA Engineer approval will be be required.