-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add blockaid related event parameters to signature request metrics #20950
Merged
+24
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
jpuri
added
the
needs-dev-review
PR needs reviews from other engineers (in order to receive required approvals)
label
Sep 19, 2023
…xtension into blockaid_metrics_fix
segun
approved these changes
Sep 21, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #20950 +/- ##
========================================
Coverage 68.42% 68.42%
========================================
Files 1006 1006
Lines 40213 40219 +6
Branches 10751 10756 +5
========================================
+ Hits 27512 27518 +6
Misses 12701 12701
☔ View full report in Codecov by Sentry. |
Builds ready [91f3f6c]
Page Load Metrics (1587 ± 67 ms)
Bundle size diffs
|
blackdevelopa
approved these changes
Sep 27, 2023
github-actions
bot
removed
the
needs-dev-review
PR needs reviews from other engineers (in order to receive required approvals)
label
Sep 27, 2023
metamaskbot
added
the
release-11.3.0
Issue or pull request that will be included in release 11.3.0
label
Sep 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-11.3.0
Issue or pull request that will be included in release 11.3.0
team-confirmations-secure-ux-PR
PRs from the confirmations team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #20859
Blockaid related event parameters were missed out to be added to metrics for signature requests. The PR fixes this.
Manual testing steps
Screenshots/Recordings
If applicable, add screenshots and/or recordings to visualize the before and after of your change.
Before
[screenshot]
After
[screenshot]
Related issues
fixes #20859
Pre-merge author checklist
Pre-merge reviewer checklist