Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add blockaid related event parameters to signature request metrics #20950

Merged
merged 9 commits into from
Sep 27, 2023

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Sep 19, 2023

Description

Fixes #20859

Blockaid related event parameters were missed out to be added to metrics for signature requests. The PR fixes this.

Manual testing steps

  1. Enable SEGMENT_FLASK_WRITE_KEY
  2. Build flask
  3. Open MM
  4. Trigger any signature from the test dapp (malicious, non malicious, etc)
  5. Check either the background console for the Segment request or your Segment project if you have set it up
  6. Ensure that field related to PPOM is displayed

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change.

Before

[screenshot]

After

[screenshot]

Related issues

fixes #20859

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained:
    • What problem this PR is solving.
    • How this problem was solved.
    • How reviewers can test my changes.
  • I’ve indicated what issue this PR is linked to: Fixes #???
  • I’ve included tests if applicable.
  • I’ve documented any added code.
  • I’ve applied the right labels on the PR (see labeling guidelines).
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added the team-confirmations-secure-ux-PR PRs from the confirmations team label Sep 19, 2023
@jpuri jpuri requested a review from a team September 19, 2023 10:12
@jpuri jpuri requested a review from a team as a code owner September 19, 2023 10:12
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jpuri jpuri added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Sep 19, 2023
@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Patch coverage: 75.00% and no project coverage change.

Comparison is base (91a0064) 68.42% compared to head (91f3f6c) 68.42%.
Report is 8 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #20950   +/-   ##
========================================
  Coverage    68.42%   68.42%           
========================================
  Files         1006     1006           
  Lines        40213    40219    +6     
  Branches     10751    10756    +5     
========================================
+ Hits         27512    27518    +6     
  Misses       12701    12701           
Files Changed Coverage Δ
...p/scripts/lib/createRPCMethodTrackingMiddleware.js 71.79% <75.00%> (+1.52%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [91f3f6c]
Page Load Metrics (1587 ± 67 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1192131442512
domContentLoaded14141917158714067
load14141917158714067
domInteractive14141917158714067
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@jpuri jpuri merged commit d4ba5e0 into develop Sep 27, 2023
9 checks passed
@jpuri jpuri deleted the blockaid_metrics_fix branch September 27, 2023 12:49
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Sep 27, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Sep 27, 2023
@metamaskbot metamaskbot added the release-11.3.0 Issue or pull request that will be included in release 11.3.0 label Sep 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.3.0 Issue or pull request that will be included in release 11.3.0 team-confirmations-secure-ux-PR PRs from the confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: PPOM metrics not present on any Signature requests
4 participants