Add blockaid related event parameters to signature request metrics (#…

…20950)
MetaMask · Sep 27, 2023 · d4ba5e0 · d4ba5e0
1 parent 7317e63
commit d4ba5e0
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 0 deletions.
diff --git a/app/scripts/lib/createRPCMethodTrackingMiddleware.js b/app/scripts/lib/createRPCMethodTrackingMiddleware.js
@@ -11,6 +11,12 @@ import {
   MetaMetricsEventName,
   MetaMetricsEventUiCustomization,
 } from '../../../shared/constants/metametrics';
+///: BEGIN:ONLY_INCLUDE_IN(blockaid)
+import {
+  BlockaidReason,
+  BlockaidResultType,
+} from '../../../shared/constants/security-provider';
+///: END:ONLY_INCLUDE_IN
 
 /**
  * These types determine how the method tracking middleware handles incoming
@@ -183,6 +189,14 @@ export default function createRPCMethodTrackingMiddleware({
         }
         const paramsExamplePassword = req?.params?.[2];
 
+        ///: BEGIN:ONLY_INCLUDE_IN(blockaid)
+        eventProperties.security_alert_response =
+          req.securityAlertResponse?.result_type ??
+          BlockaidResultType.NotApplicable;
+        eventProperties.security_alert_reason =
+          req.securityAlertResponse?.reason ?? BlockaidReason.notApplicable;
+        ///: END:ONLY_INCLUDE_IN
+
         const msgData = {
           msgParams: {
             ...paramsExamplePassword,

diff --git a/app/scripts/lib/createRPCMethodTrackingMiddleware.test.js b/app/scripts/lib/createRPCMethodTrackingMiddleware.test.js
@@ -6,6 +6,10 @@ import {
   MetaMetricsEventUiCustomization,
 } from '../../../shared/constants/metametrics';
 import { SECOND } from '../../../shared/constants/time';
+import {
+  BlockaidReason,
+  BlockaidResultType,
+} from '../../../shared/constants/security-provider';
 import createRPCMethodTrackingMiddleware from './createRPCMethodTrackingMiddleware';
 
 const trackEvent = jest.fn();
@@ -115,6 +119,10 @@ describe('createRPCMethodTrackingMiddleware', () => {
       const req = {
         method: MESSAGE_TYPE.ETH_SIGN,
         origin: 'some.dapp',
+        securityAlertResponse: {
+          result_type: BlockaidResultType.Malicious,
+          reason: BlockaidReason.maliciousDomain,
+        },
       };
 
       const res = {
@@ -128,6 +136,8 @@ describe('createRPCMethodTrackingMiddleware', () => {
         event: MetaMetricsEventName.SignatureRequested,
         properties: {
           signature_type: MESSAGE_TYPE.ETH_SIGN,
+          security_alert_response: BlockaidResultType.Malicious,
+          security_alert_reason: BlockaidReason.maliciousDomain,
         },
         referrer: { url: 'some.dapp' },
       });