Initialize composable observable store after update #20468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Builds ready [10f5431]
Page Load Metrics (1615 ± 78 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Gudahtt
force-pushed
the
rename-backup-module
branch
from
f475859 to
31de96a
Compare
Gudahtt
force-pushed
the
initialize-composable-observable-store-after-structure-update
branch
from
10f5431 to
3b4b416
Compare
Builds ready [3b4b416]
Page Load Metrics (1506 ± 34 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Codecov Report
@@ Coverage Diff @@
## develop #20468 +/- ##
========================================
Coverage 68.68% 68.68%
========================================
Files 991 991
Lines 38440 38444 +4
Branches 10327 10329 +2
========================================
+ Hits 26402 26405 +3
- Misses 12038 12039 +1
|
Gudahtt
force-pushed
the
initialize-composable-observable-store-after-structure-update
branch
2 times, most recently
from
4d784de to
d294f12
Compare
The composable observable store now updates state immediately when the structure is updated. Previously each store would only be updated after the first state change. This ensures that the composable observable store state is always complete.
Gudahtt
force-pushed
the
initialize-composable-observable-store-after-structure-update
branch
from
d294f12 to
861e7db
Compare
We now use the nullish coalescing operator when checkint store.state, so that we don't accidentally ignore falsy state. Co-authored-by: Frederik Bolding <[email protected]>
A change on `develop` required another state update.
Builds ready [9459765]
Page Load Metrics (1770 ± 69 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
FrederikBolding
approved these changes
Aug 17, 2023
dicv2
approved these changes
Aug 17, 2023
Gudahtt
deleted the
initialize-composable-observable-store-after-structure-update
branch
metamaskbot
added
the
release-10.36.0
Gudahtt
added
release-10.34.5
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
The composable observable store now updates state immediately when the structure is updated. Previously each store would only be updated after the first state change. This ensures that the composable observable store state is always complete.
Manual Testing Steps
This PR should ensure that the background state and the UI state contains an entry for every single controller immediately upon construction, without needing to wait for each controller to update. This is most obvious by looking at the background state snapshot captured by the
errors.spec.jstest suite. You can manually test this by looking at the background state in the background console shortly after the extension starts (e.g. using breakpoints or one of the state hooks).Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Boardlabel.In this case, a QA Engineer approval will be be required.