Add types of hidden properties to Sentry data #20457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
Gudahtt
added
release-blocker
Gudahtt
force-pushed
the
use-unflattened-sentry-state-for-sentry
branch
from
8eac93c to
de1237b
Compare
Gudahtt
force-pushed
the
enhance-masked-sentry-data
branch
from
55a7edb to
8eb3eaa
Compare
Codecov Report
@@ Coverage Diff @@
## develop #20457 +/- ##
===========================================
- Coverage 68.71% 68.71% -0.00%
===========================================
Files 991 991
Lines 38426 38428 +2
Branches 10312 10313 +1
===========================================
Hits 26402 26402
- Misses 12024 12026 +2
|
dan437
previously approved these changes
Aug 16, 2023
danjm
added
the
release-10.34.5
Merged
Gudahtt
force-pushed
the
use-unflattened-sentry-state-for-sentry
branch
from
de1237b to
a88fb53
Compare
Base automatically changed from
use-unflattened-sentry-state-for-sentry
to
develop
August 16, 2023 17:51
Gudahtt
dismissed stale reviews from dan437 and danjm
The base branch was changed.
Gudahtt
force-pushed
the
enhance-masked-sentry-data
branch
from
8eb3eaa to
495cafa
Compare
|
I'm investigating the e2e test failures. Looks like a timing issue. |
mcmire
previously approved these changes
Aug 16, 2023
Gudahtt
force-pushed
the
enhance-masked-sentry-data
branch
from
f13932f to
a971500
Compare
|
I found that certain background state properties were causing inconsistencies between Chrome and Firefox because they were set to For now I have excluded these properties from the snapshots. In each case I have a better solution in mind that I will pursue in later PRs, but that need not block this PR. |
Builds ready [a971500]
Page Load Metrics (1547 ± 54 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
The masked wallet state object sent to Sentry has been updated to include the type of each property omitted from the mask. This lets us at least see the full state shape, making it easier to see when errors are caused by invalid state. Relates to #20449
The state snapshot tests have been updated to exclude properties that were shown to differ between runs.
Gudahtt
force-pushed
the
enhance-masked-sentry-data
branch
from
a971500 to
49d79aa
Compare
danjm
approved these changes
Aug 16, 2023
Builds ready [49d79aa]
Page Load Metrics (1563 ± 46 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
darkwing
approved these changes
Aug 16, 2023
metamaskbot
added
the
release-10.36.0
Gudahtt
removed
the
release-10.36.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
The masked wallet state object sent to Sentry has been updated to include the type of each property omitted from the mask. This lets us at least see the full state shape, making it easier to see when errors are caused by invalid state.
Relates to #20449
Manual Testing Steps
This is demonstrated by the "errors" e2e tests (see the state snapshots in the diff). You can manually test by performing the same steps as the tests.
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Boardlabel.In this case, a QA Engineer approval will be be required.