Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version v10.30.3 RC #19159

Merged
merged 4 commits into from
May 15, 2023
Merged

Version v10.30.3 RC #19159

merged 4 commits into from
May 15, 2023

Conversation

metamaskbot
Copy link
Collaborator

📦 🚀

metamaskbot and others added 3 commits May 15, 2023 21:04
@metamaskbot
Version v10.30.3
2897607
@Gudahtt
Support hex and number net_version responses
77ef06a 
Hex and number responses from the `net_version` request are now
accepted. While most chains return decimal strings for this request,
some chains were returning hex responses instead and failing our
validation for this request (which was added in v10.30.0). This
resolves that problem.

Support for number responses was added because it likely worked in
older versions as well, so support is maintained to avoid similar
problems.

Fixes #19151
@Gudahtt
Update the changelog
a98b400
@Gudahtt Gudahtt marked this pull request as ready for review May 15, 2023 21:15
@Gudahtt Gudahtt requested a review from a team as a code owner May 15, 2023 21:15
@Gudahtt Gudahtt requested a review from jpuri May 15, 2023 21:15
@Gudahtt Gudahtt temporarily deployed to desktop May 15, 2023 21:15 — with GitHub Actions Inactive
tmashuang
tmashuang previously approved these changes May 15, 2023
View reviewed changes
Copy link
Contributor

@tmashuang tmashuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@metamaskbot
Copy link
Collaborator Author

Builds ready [a98b400]
Page Load Metrics (1725 ± 74 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint95156126189
domContentLoaded14841983170716278
load14842005172515474
domInteractive14841983170716278

@codecov
Copy link

codecov bot commented May 15, 2023 •
edited
Loading

Codecov Report

Merging #19159 (f74befc) into master (33fd787) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master   #19159   +/-   ##
=======================================
  Coverage   68.42%   68.43%           
=======================================
  Files         946      946           
  Lines       35911    35916    +5     
  Branches     9250     9252    +2     
=======================================
+ Hits        24571    24576    +5     
  Misses      11340    11340
Impacted Files Coverage Δ
.../scripts/controllers/network/network-controller.ts 97.41% <100.00%> (+0.05%) ⬆️

@Gudahtt
Add unit test coverage for lookupNetwork
f74befc 
The changes to network ID validation are now covered by unit tests.
Test cases for the invalid network ID case have been added as well,
since that is covered on `develop` but not here.
@Gudahtt Gudahtt temporarily deployed to desktop May 15, 2023 21:58 — with GitHub Actions Inactive
@metamaskbot
Copy link
Collaborator Author

Builds ready [f74befc]
Page Load Metrics (1525 ± 28 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint95137114115
domContentLoaded1411160015145225
load1411162115255828
domInteractive1411160015145225

@danjm danjm merged commit 42197a3 into master May 15, 2023
@danjm danjm deleted the Version-v10.30.3 branch May 15, 2023 22:28
@github-actions github-actions bot locked and limited conversation to collaborators May 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tmashuang tmashuang tmashuang approved these changes

@danjm danjm danjm approved these changes

@Gudahtt Gudahtt Gudahtt approved these changes

@jpuri jpuri Awaiting requested review from jpuri jpuri is a code owner automatically assigned from MetaMask/extension-devs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@metamaskbot @Gudahtt @danjm @tmashuang