Version v10.30.2 RC (#19109)

* Version v10.30.2 * Ensure the GasDetailsItem component can handle a tx with a maxPriorityFee of 0 (#19102) * Ensure the GasDetailsItem component can handle a tx with a maxPriorityFee of 0 * Clean up code * Update ui/components/app/gas-details-item/gas-details-item.js Co-authored-by: Mark Stacey <[email protected]> --------- Co-authored-by: Mark Stacey <[email protected]> * Backport the `@metamask/message-manager` update to v5 (#19110) The `@metamask/message-manager` update to v5 has been backported to the v10.30.x release branch. This update includes three breaking changes, but two (bump in minimum supported Node.js version, and change in type from `Map` to `Record`) don't affect this project. The only breaking change requiring changes was the addition of the `getCurrentChainId` constructor parameter for the TypedMessageManger. * Update changelog --------- Co-authored-by: MetaMask Bot <[email protected]> Co-authored-by: Dan J Miller <[email protected]> Co-authored-by: Mark Stacey <[email protected]>
MetaMask · May 12, 2023 · 33fd787 · 33fd787
1 parent 409759d
commit 33fd787
Show file tree

Hide file tree

Showing 11 changed files with 863 additions and 448 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [10.30.2]
+### Changed
+- Improve `eth_signTypedData_v4` validation ([#19110](https://github.com/MetaMask/metamask-extension/pull/19110))
+
+### Fixed
+- Fix crash when confirming an approval where the `maxPriorityFeePerGas` is zero ([#19102](https://github.com/MetaMask/metamask-extension/pull/19102))
+
 ## [10.30.1]
 ### Fixed
 - Disable Flask RPC test to fix failing build ([#19011](https://github.com/MetaMask/metamask-extension/pull/19011))
@@ -3711,7 +3718,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Uncategorized
 - Added the ability to restore accounts from seed words.
 
-[Unreleased]: https://github.com/MetaMask/metamask-extension/compare/v10.30.1...HEAD
+[Unreleased]: https://github.com/MetaMask/metamask-extension/compare/v10.30.2...HEAD
+[10.30.2]: https://github.com/MetaMask/metamask-extension/compare/v10.30.1...v10.30.2
 [10.30.1]: https://github.com/MetaMask/metamask-extension/compare/v10.30.0...v10.30.1
 [10.30.0]: https://github.com/MetaMask/metamask-extension/compare/v10.29.0...v10.30.0
 [10.29.0]: https://github.com/MetaMask/metamask-extension/compare/v10.28.3...v10.29.0

diff --git a/app/scripts/controllers/sign.ts b/app/scripts/controllers/sign.ts
@@ -110,6 +110,7 @@ export type SignControllerOptions = {
   getState: () => any;
   metricsEvent: (payload: any, options?: any) => void;
   securityProviderRequest: SecurityProviderRequest;
+  getCurrentChainId: () => string;
 };
 
 /**
@@ -152,6 +153,7 @@ export default class SignController extends BaseControllerV2<
    * @param options.getState - Callback to retrieve all user state.
    * @param options.metricsEvent - A function for emitting a metric event.
    * @param options.securityProviderRequest - A function for verifying a message, whether it is malicious or not.
+   * @param options.getCurrentChainId - Returns the chain ID of the current selected network.
    */
   constructor({
     messenger,
@@ -160,6 +162,7 @@ export default class SignController extends BaseControllerV2<
     getState,
     metricsEvent,
     securityProviderRequest,
+    getCurrentChainId,
   }: SignControllerOptions) {
     super({
       name: controllerName,
@@ -188,6 +191,8 @@ export default class SignController extends BaseControllerV2<
       undefined,
       undefined,
       securityProviderRequest,
+      undefined,
+      getCurrentChainId,
     );
 
     this._messageManagers = [

diff --git a/app/scripts/metamask-controller.js b/app/scripts/metamask-controller.js
@@ -1185,6 +1185,8 @@ export default class MetamaskController extends EventEmitter {
       metricsEvent: this.metaMetricsController.trackEvent.bind(
         this.metaMetricsController,
       ),
+      getCurrentChainId: () =>
+        this.networkController.store.getState().provider.chainId,
     });
 
     this.swapsController = new SwapsController({