Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make mozilla-lint-beta.sh executable #18412

Merged
merged 1 commit into from
Apr 3, 2023
Merged

Conversation

PeterYinusa
Copy link
Contributor

error on the RC branch

#!/bin/bash -eo pipefail
.circleci/scripts/mozilla-lint-beta.sh

/bin/bash: .circleci/scripts/mozilla-lint-beta.sh: Permission denied

Exited with code exit status 126
CircleCI received exit code 126

This file was introduced here: #18403

I ran chmod +x .circleci/scripts/mozilla-lint-beta.sh locally and committed that

@PeterYinusa PeterYinusa marked this pull request as ready for review April 3, 2023 11:03
@PeterYinusa PeterYinusa requested review from a team, kumavis and brad-decker as code owners April 3, 2023 11:03
@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

@danjm danjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@metamaskbot
Copy link
Collaborator

Builds ready [8dabf3e]
Page Load Metrics (1448 ± 24 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint89164102157
domContentLoaded1356156614445325
load1360156614485124
domInteractive1356156614445325
Bundle size diffs
  • background: 0 bytes
  • ui: 0 bytes
  • common: 0 bytes

@PeterYinusa PeterYinusa merged commit 720b701 into develop Apr 3, 2023
@PeterYinusa PeterYinusa deleted the executable-file-update branch April 3, 2023 11:27
@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Merging #18412 (8dabf3e) into develop (50767dd) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop   #18412   +/-   ##
========================================
  Coverage    64.82%   64.82%           
========================================
  Files          930      930           
  Lines        35763    35763           
  Branches      9191     9191           
========================================
  Hits         23181    23181           
  Misses       12582    12582           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants