Ensure that firefox linting of beta builds only happens on beta build… #18403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Gudahtt
reviewed
Mar 31, 2023
|
|
||
| current_commit_msg=$(git show -s --format='%s' HEAD) | ||
|
|
||
| if [[ $current_commit_msg =~ Version[[:space:]](v[[:digit:]]+.[[:digit:]]+.[[:digit:]]+[-]beta.[[:digit:]]) ]] |
There was a problem hiding this comment.
Would be nice to share this criteria between bash scripts
There was a problem hiding this comment.
@Gudahtt that sounds good... any guidance on how to do that in bash?
There was a problem hiding this comment.
cool, chatted with Mark
We could move this code to another script and invoke that here, but we can do that in the future
Builds ready [e730498]
Page Load Metrics (1744 ± 126 ms)
Bundle size diffs
|
Codecov Report
@@ Coverage Diff @@
## develop #18403 +/- ##
========================================
Coverage 64.78% 64.78%
========================================
Files 927 927
Lines 35698 35698
Branches 9164 9164
========================================
Hits 23126 23126
Misses 12572 12572 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
pedronfigueiredo
approved these changes
Apr 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the failure we are seeing on release builds here: https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/41331/workflows/b6b2b01e-425f-452b-8dcb-409605c61e98/jobs/1149313
This is happening because the beta build isn't happening:
Commit message does not match commit message for beta pattern; skipping beta automation build
from https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/41331/workflows/b6b2b01e-425f-452b-8dcb-409605c61e98/jobs/1149172/steps, and the linting of that beta build is running even when the build doesn't exist
This PR ensures that the
yarn mozilla-lintcommand is only run under the same conditions under which the beta build is created. In particular, if the commit message matches the beta commit structure we have set for triggering a beta build.