Adding ModalOverlay component #18161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgewrmarshall
added
area-UI
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
12 tasks
georgewrmarshall
force-pushed
the
feat/18033/modal-overlay
branch
from
f863fdf to
762c0fe
Compare
georgewrmarshall
requested review from
pedronfigueiredo,
NidhiKJha and
garrettbear
and removed request for
pedronfigueiredo
georgewrmarshall
force-pushed
the
feat/18033/modal-overlay
branch
from
762c0fe to
47f159e
Compare
darkwing
previously approved these changes
Mar 15, 2023
georgewrmarshall
force-pushed
the
feat/18033/modal-overlay
branch
from
47f159e to
2f62e47
Compare
georgewrmarshall
force-pushed
the
feat/18033/modal-overlay
branch
from
2f62e47 to
73b110d
Compare
Codecov Report
@@ Coverage Diff @@
## develop #18161 +/- ##
===========================================
- Coverage 64.47% 64.14% -0.33%
===========================================
Files 909 905 -4
Lines 35250 35525 +275
Branches 9041 9025 -16
===========================================
+ Hits 22725 22785 +60
- Misses 12525 12740 +215
... and 60 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Builds ready [73b110d]
Page Load Metrics (1639 ± 66 ms)
Bundle size diffs
|
georgewrmarshall
force-pushed
the
feat/18033/modal-overlay
branch
2 times, most recently
from
f370ec1 to
d694497
Compare
jest.config.js
Outdated
| @@ -13,7 +13,7 @@ module.exports = { | |||
| '<rootDir>/development/fitness-functions/**/*.test.(js|ts|tsx)', | |||
| ], | |||
| coverageDirectory: './coverage', | |||
| coveragePathIgnorePatterns: ['.stories.js', '.snap'], | |||
| coveragePathIgnorePatterns: ['.stories.*', '.snap'], | |||
There was a problem hiding this comment.
Coverage was failing because it's including stories.tsx files
Before
After
Builds ready [888ec2e]
Page Load Metrics (1551 ± 38 ms)
Bundle size diffs
|
darkwing
previously approved these changes
Mar 21, 2023
garrettbear
previously approved these changes
Mar 22, 2023
georgewrmarshall
dismissed stale reviews from garrettbear and darkwing
via
4ffef07
georgewrmarshall
force-pushed
the
feat/18033/modal-overlay
branch
from
888ec2e to
4ffef07
Compare
Builds ready [4ffef07]
Page Load Metrics (1940 ± 208 ms)
Bundle size diffs
|
garrettbear
approved these changes
Mar 23, 2023
NidhiKJha
approved these changes
Mar 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Adding
ModalOverlaycomponent as a part ofModalcomponent #18156 according to insight reportScreenshots/Screencaps
After
after.mov
Manual Testing Steps
ModalOverlayin the search bar in the panel on the leftPre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Boardlabel.In this case, a QA Engineer approval will be be required.