Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ext] Create component: ModalOverlay #18033

Closed
8 tasks
georgewrmarshall opened this issue Mar 7, 2023 · 0 comments · Fixed by #18161
Closed
8 tasks

[Ext] Create component: ModalOverlay #18033

georgewrmarshall opened this issue Mar 7, 2023 · 0 comments · Fixed by #18161
Assignees
@georgewrmarshall
Labels
area-UI Relating to the user interface. team-design-system All issues relating to design system in Extension

Comments

@georgewrmarshall
Copy link
Contributor

Description

Create a reusable UI component for ModalOverlay according to the insight report

References

Modal Audit FigJam
Figma component
UI component guidelines
Styling guidelines
Testing guidelines: TBC

Files needed

  • index.js
  • index.scss
  • modal-overlay.js
  • modal-overlay.stories.js
  • modal-overlay.test.js
  • README.mdx

Technical details

TBC

Acceptance criteria

  • Uses color, typography, shadows design tokens
  • Uses semantic html
  • PropTypes have descriptions
  • Has storybook story with controls
  • Has documentation in MDX
  • Has unit tests and 90% coverage
  • Works in Chrome and Firefox
  • Performance tested: no unnecessary re-renders or other performance concerns
@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system in Extension label Mar 7, 2023
@georgewrmarshall georgewrmarshall self-assigned this Mar 7, 2023
@georgewrmarshall georgewrmarshall added area-UI Relating to the user interface. IA/NAV labels Mar 7, 2023
@xinnanyemm xinnanyemm changed the title Create component: ModalOverlay [Ext] Create component: ModalOverlay Mar 9, 2023
@georgewrmarshall georgewrmarshall mentioned this issue Mar 15, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@georgewrmarshall georgewrmarshall

Labels
area-UI Relating to the user interface. team-design-system All issues relating to design system in Extension
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding ModalOverlay component MetaMask/metamask-extension
2 participants
@georgewrmarshall and others