Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for hovering any Address parsed on Signed Type Data screen does not display the pointer anymore #18046

Merged
merged 5 commits into from
Mar 23, 2023
Merged

Fix for hovering any Address parsed on Signed Type Data screen does not display the pointer anymore #18046

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
29e2b6b
Signed Type Data address hover fix
aleksandar-mihajlovic Mar 8, 2023
34b2fb8
Snapshots fix
aleksandar-mihajlovic Mar 8, 2023
b1f05cf
Snapshots update fix
aleksandar-mihajlovic Mar 8, 2023
c95a2d0
Merge branch 'develop' into signed-type-data-pointer-fix
aleksandar-mihajlovic Mar 9, 2023
56c9ac6
Update snapshot
aleksandar-mihajlovic Mar 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions ui/components/app/signature-request/__snapshots__/signature-request.component.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,7 @@ exports[`Signature Request Component render should match snapshot when we are us
</div>
</div>
<div
class="address__name"
class="tx-insight-component-address__name"
>
0xCD2...D826
</div>
Expand Down Expand Up @@ -445,7 +445,7 @@ exports[`Signature Request Component render should match snapshot when we are us
</div>
</div>
<div
class="address__name"
class="tx-insight-component-address__name"
>
0xDea...beeF
</div>
Expand Down Expand Up @@ -580,7 +580,7 @@ exports[`Signature Request Component render should match snapshot when we are us
</div>
</div>
<div
class="address__name"
class="tx-insight-component-address__name"
>
0xbBb...BBbB
</div>
Expand Down Expand Up @@ -656,7 +656,7 @@ exports[`Signature Request Component render should match snapshot when we are us
</div>
</div>
<div
class="address__name"
class="tx-insight-component-address__name"
>
0xB0B...Ea57
</div>
Expand Down Expand Up @@ -732,7 +732,7 @@ exports[`Signature Request Component render should match snapshot when we are us
</div>
</div>
<div
class="address__name"
class="tx-insight-component-address__name"
>
0xB0B...0000
</div>
Expand Down Expand Up @@ -1144,7 +1144,7 @@ exports[`Signature Request Component render should match snapshot when we want t
</div>
</div>
<div
class="address__name"
class="tx-insight-component-address__name"
>
0xCD2...D826
</div>
Expand Down Expand Up @@ -1220,7 +1220,7 @@ exports[`Signature Request Component render should match snapshot when we want t
</div>
</div>
<div
class="address__name"
class="tx-insight-component-address__name"
>
0xDea...beeF
</div>
Expand Down Expand Up @@ -1355,7 +1355,7 @@ exports[`Signature Request Component render should match snapshot when we want t
</div>
</div>
<div
class="address__name"
class="tx-insight-component-address__name"
>
0xbBb...BBbB
</div>
Expand Down Expand Up @@ -1431,7 +1431,7 @@ exports[`Signature Request Component render should match snapshot when we want t
</div>
</div>
<div
class="address__name"
class="tx-insight-component-address__name"
>
0xB0B...Ea57
</div>
Expand Down Expand Up @@ -1507,7 +1507,7 @@ exports[`Signature Request Component render should match snapshot when we want t
</div>
</div>
<div
class="address__name"
class="tx-insight-component-address__name"
>
0xB0B...0000
</div>
Expand Down
2 changes: 1 addition & 1 deletion ui/components/app/transaction-decoding/components/decoding/address/address.component.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ const Address = ({
</div>

<div
className="address__name"
className="tx-insight-component-address__name"
onClick={() => setShowNicknamePopovers(true)}
>
{recipientToRender}
Expand Down
19 changes: 10 additions & 9 deletions ui/components/app/transaction-decoding/components/decoding/address/index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
.tx-insight-content {
.tx-insight-component-address {
display: flex;
align-items: center;
cursor: pointer;
overflow: visible;
.tx-insight-component-address {
display: flex;
align-items: center;
overflow: visible;

&__sender-icon {
padding-right: 5px;
}

&__sender-icon {
padding-right: 5px;
}
&__name {
cursor: pointer;
}
}
10 changes: 5 additions & 5 deletions ui/pages/confirm-signature-request/__snapshots__/index.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,7 @@ exports[`Signature Request Component render should match snapshot 1`] = `
</div>
</div>
<div
class="address__name"
class="tx-insight-component-address__name"
>
0xCD2...D826
</div>
Expand Down Expand Up @@ -444,7 +444,7 @@ exports[`Signature Request Component render should match snapshot 1`] = `
</div>
</div>
<div
class="address__name"
class="tx-insight-component-address__name"
>
0xDea...beeF
</div>
Expand Down Expand Up @@ -579,7 +579,7 @@ exports[`Signature Request Component render should match snapshot 1`] = `
</div>
</div>
<div
class="address__name"
class="tx-insight-component-address__name"
>
0xbBb...BBbB
</div>
Expand Down Expand Up @@ -655,7 +655,7 @@ exports[`Signature Request Component render should match snapshot 1`] = `
</div>
</div>
<div
class="address__name"
class="tx-insight-component-address__name"
>
0xB0B...Ea57
</div>
Expand Down Expand Up @@ -731,7 +731,7 @@ exports[`Signature Request Component render should match snapshot 1`] = `
</div>
</div>
<div
class="address__name"
class="tx-insight-component-address__name"
>
0xB0B...0000
</div>
Expand Down