-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for hovering any Address parsed on Signed Type Data screen does not display the pointer anymore #18046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [b1f05cf]
Page Load Metrics (1603 ± 70 ms)
Bundle size diffs
|
Codecov Report
@@ Coverage Diff @@
## develop #18046 +/- ##
========================================
Coverage 63.86% 63.86%
========================================
Files 908 908
Lines 35391 35391
Branches 8966 8966
========================================
Hits 22600 22600
Misses 12791 12791
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Verified by QA |
Looks good from QA |
jpuri
previously approved these changes
Mar 8, 2023
# Conflicts: # ui/components/app/signature-request/__snapshots__/signature-request.component.test.js.snap
Builds ready [56c9ac6]
Page Load Metrics (1534 ± 41 ms)
Bundle size diffs
|
NidhiKJha
approved these changes
Mar 14, 2023
brad-decker
approved these changes
Mar 22, 2023
danjm
approved these changes
Mar 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Added fix, so now when hovering over address on Signed Type Data screen cursor pointer shows up.
Screenshot
Before
After
Unit tests
Lint
Manual Testing Steps