Prevent user from editing a contract interaction created by a dapp #16498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
darkwing
reviewed
Nov 15, 2022
| @@ -1158,11 +1158,13 @@ export default class ConfirmTransactionBase extends Component { | |||
| } = this.getNavigateTxData(); | |||
|
|
|||
| let functionType; | |||
| let isContractInteractionFromDapp = false; | |||
There was a problem hiding this comment.
Can we make this a const and set its value to:
const isContractInteractionFromDapp = txData.type === TRANSACTION_TYPES.CONTRACT_INTERACTION && txData.origin !== 'metamask';
...and use that for the if?
I don't think this is accurate. Contract interactions in general were not editable prior to v10.21.0, but simple send transactions suggested by dapps were editable. Edit: Oh, but this PR still allows simple sends from dapps to be edited, sorry I missed that. |
Gudahtt
reviewed
Nov 15, 2022
Gudahtt
approved these changes
Nov 15, 2022
brad-decker
approved these changes
Nov 15, 2022
darkwing
approved these changes
Nov 15, 2022
|
From QA looks good! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes problem introduced in #15812
As of that PR, it became possible for users to edit contract interact transactions. That is okay if the transaction originates from MetaMask, but not if the transaction originates from a dapp. Editing the recipient or the asset type can have unexpected consequences in that case, include allowing the user to transfer tokens to a smart contract address.
This PR prevents the user from editing contract interactions from a dapp. This was the way things were prior to v10.21.0
An e2e test is added to prevent such a regression in the future