Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix display of edit button on confirm screen when sending tx with data to contract #15812

Merged
merged 1 commit into from
Sep 21, 2022

Conversation

danjm
Copy link
Contributor

@danjm danjm commented Sep 13, 2022

Fixes #15465

The fix adds an "onEdit" proper to the base confirmation component used for contract interactions (the "token method" route).

(Sidenote, the "token method" path is misnamed)

@danjm danjm requested a review from a team as a code owner September 13, 2022 15:46
@danjm danjm requested a review from ryanml September 13, 2022 15:46
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@PeterYinusa PeterYinusa added this to the v10.20.0 milestone Sep 13, 2022
@metamaskbot
Copy link
Collaborator

Builds ready [e083ae0]
Page Load Metrics (1782 ± 105 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint961751192311
domContentLoaded154624751768221106
load157624751782219105
domInteractive154624751768221106

Copy link
Contributor

@brad-decker brad-decker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brad-decker brad-decker merged commit 12c0a8d into develop Sep 21, 2022
@brad-decker brad-decker deleted the fix-edit-tx-data-contract-send branch September 21, 2022 16:22
@github-actions github-actions bot locked and limited conversation to collaborators Sep 21, 2022
@PeterYinusa PeterYinusa modified the milestones: v10.20.0, v10.21.0 Sep 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Cannot Edit a Tx Send to a Contract if it Contains Hex Data
6 participants