Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync develop with master v10.21.2 #16399

Merged
merged 5 commits into from
Nov 8, 2022
Merged

Sync develop with master v10.21.2 #16399

merged 5 commits into from
Nov 8, 2022

Conversation

seaona
Copy link
Contributor

@seaona seaona commented Nov 7, 2022

Explanation

Sync develop with master branch to last state.

Screenshots/Screencaps

Before

After

Manual Testing Steps

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@seaona seaona requested a review from a team as a code owner November 7, 2022 17:07
@seaona seaona requested a review from PeterYinusa November 7, 2022 17:07
@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2022

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [6a6b767]
Page Load Metrics (2378 ± 182 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint933448394836401
domContentLoaded173934482360387186
load179634482378378182
domInteractive173934482360387186

@seaona seaona merged commit e7d6684 into develop Nov 8, 2022
@seaona seaona deleted the sync-master branch November 8, 2022 09:54
@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants