Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix approve transaction call in _onBootCleanUp #16382

Merged
merged 3 commits into from
Nov 4, 2022
Merged

Fix approve transaction call in _onBootCleanUp #16382

merged 3 commits into from
Nov 4, 2022

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Nov 4, 2022

Fixes: #16368

The PR fixes issue in transaction controller. It seems that currently this is causing error which is caught by sentry. The transaction were completed.

@jpuri jpuri requested a review from a team as a code owner November 4, 2022 15:23
@jpuri jpuri requested a review from segun November 4, 2022 15:23
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2022

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [799f6fd]
Page Load Metrics (2046 ± 87 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint8614199115
domContentLoaded16392389203118890
load16972389204618087
domInteractive16392388203118890

@jpuri jpuri merged commit 83ec64d into develop Nov 4, 2022
@jpuri jpuri deleted the txn_issue_fix branch November 4, 2022 17:47
@github-actions github-actions bot locked and limited conversation to collaborators Nov 4, 2022
@PeterYinusa PeterYinusa added this to the v10.21.2 milestone Nov 4, 2022
@seaona
Copy link
Contributor

seaona commented Nov 7, 2022

Testing steps for verifying the fix:

txparams.mp4

From QA looks good.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: Cannot read properties of undefined (reading 'txParams')
7 participants