[MV3] Fix e2e incremental security test for MV3 test build #16265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [d93b7d8]
Page Load Metrics (2458 ± 115 ms)
|
darkwing
approved these changes
Oct 25, 2022
PeterYinusa
reviewed
Oct 26, 2022
| @@ -130,6 +130,7 @@ describe('Incremental Security', function () { | |||
| const revealedSeedPhrase = await driver.findElement( | |||
| '.reveal-seed-phrase__secret-words', | |||
| ); | |||
| await driver.waitForNonEmptyElement(revealedSeedPhrase); | |||
There was a problem hiding this comment.
If we know the seed phrase, can we just use driver.waitForSelector instead, and remove this new method?
There was a problem hiding this comment.
ty! not in this case, as here we are going to the complete onboarding flow for Create New Wallet, so every time we run it, it's a different seed-phrase
There was a problem hiding this comment.
Oh my bad, I didn't realise it was creating a new wallet. Thanks for getting back to me
PeterYinusa
approved these changes
Oct 27, 2022
| @@ -130,6 +130,7 @@ describe('Incremental Security', function () { | |||
| const revealedSeedPhrase = await driver.findElement( | |||
| '.reveal-seed-phrase__secret-words', | |||
| ); | |||
| await driver.waitForNonEmptyElement(revealedSeedPhrase); | |||
There was a problem hiding this comment.
Oh my bad, I didn't realise it was creating a new wallet. Thanks for getting back to me
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
On the mv3 test build, the e2e test for incremental security is failing due to a tiny delay when we render the seed phrase inside the div box.
This fixes the issue by waiting until the element is not empty. This way we make sure the seed phrase is rendered when we make the assertion.
Note: in MV2 this error does not surface as it's slightly faster on rendering the seed phrase. We'll introduce performance metrics for calculating these delays introduced on the MV3 build.
More Information
encrypt-decrypttest for MV3 test build #16264Screenshots/Screencaps
Before
After
Manual Testing Steps
yarn test:e2e:single test/e2e/tests/incremental-security.spec.js --browser=chromePre-Merge Checklist
+ If there are functional changes: