Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MV3] Fix e2e encrypt-decrypt test for MV3 test build #16264

Merged
merged 4 commits into from
Oct 27, 2022
Merged

Conversation

seaona
Copy link
Contributor

@seaona seaona commented Oct 25, 2022

Explanation

On the mv3 test build, the e2e test for encrypt-decrypt is failing due to a tiny delay when we render the decrypted text inside MetaMask popup.
This fixes the issue by grabbing the element by its content. This way we make sure the element is there when we make the assertion.

Note: in MV2 this error does not surface as it's slightly faster on rendering the decrypted message. Though tiny delay is not visible on the naked eye, we'll introduce performance metrics for calculating these delays introduced on the MV3 build.

More Information

Screenshots/Screencaps

Before

image

After

image

Manual Testing Steps

  1. Build the mv3 test yarn build:test:mv3
  2. Run the failing test and check it's working yarn test:e2e:single test/e2e/tests/encrypt-decrypt.spec.js --browser=chrome

Pre-Merge Checklist

  • PR template is filled out
  • IF this PR fixes a bug, a test that would have caught the bug has been added
  • PR is linked to the appropriate GitHub issue
  • PR has been added to the appropriate release Milestone

+ If there are functional changes:

  • Manual testing complete & passed
  • "Extension QA Board" label has been applied

@seaona seaona requested a review from a team as a code owner October 25, 2022 09:02
@seaona seaona requested a review from hmalik88 October 25, 2022 09:02
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [bd13506]
Page Load Metrics (2268 ± 100 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint912591213617
domContentLoaded188826362254216104
load188826362268209100
domInteractive188826362254216104

@seaona seaona merged commit d452613 into develop Oct 27, 2022
@seaona seaona deleted the e2e-mv3-encrypt branch October 27, 2022 12:46
@github-actions github-actions bot locked and limited conversation to collaborators Oct 27, 2022
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: [MV3] e2e failure for Encrypt Decrypt spec
5 participants