Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Fix permissions in MV3 manifest (#15980)" #16021

Merged
merged 2 commits into from
Sep 30, 2022
Merged

Revert "Fix permissions in MV3 manifest (#15980)" #16021

merged 2 commits into from
Sep 30, 2022

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Sep 28, 2022

Revert PR #15980

@jpuri jpuri requested a review from a team as a code owner September 28, 2022 15:05
@jpuri jpuri requested a review from garrettbear September 28, 2022 15:05
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [0da97d9]
Page Load Metrics (2107 ± 94 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint88138102115
domContentLoaded16352347208518991
load16352424210719594
domInteractive16352347208518991

digiwand
digiwand approved these changes Sep 30, 2022
View reviewed changes
Copy link
Contributor

@digiwand digiwand left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have plans to add a setting to allow users to restrict / unrestrict scope of extension use (slack)

@jpuri jpuri merged commit 300cb6e into develop Sep 30, 2022
@jpuri jpuri deleted the revert_permission_change branch September 30, 2022 14:31
@github-actions github-actions bot locked and limited conversation to collaborators Sep 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@digiwand digiwand digiwand approved these changes

@darkwing darkwing darkwing approved these changes

@garrettbear garrettbear Awaiting requested review from garrettbear garrettbear is a code owner automatically assigned from MetaMask/extension-devs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jpuri @metamaskbot @darkwing @digiwand