Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix permissions in MV3 manifest #15980

Merged
merged 2 commits into from
Sep 27, 2022
Merged

Fix permissions in MV3 manifest #15980

merged 2 commits into from
Sep 27, 2022

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Sep 26, 2022

PR aligns MV3 permission to MV2.

For some reason, we had kep very board permissions when starting work on MV3.

@jpuri jpuri requested a review from a team as a code owner September 26, 2022 18:07
@jpuri jpuri requested a review from darkwing September 26, 2022 18:07
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [5c6bf69]
Page Load Metrics (2260 ± 66 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint872422227504242
domContentLoaded18732457224113263
load18732457226013766
domInteractive18732457224113263

@metamaskbot
Copy link
Collaborator

Builds ready [ffaba16]
Page Load Metrics (2492 ± 104 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint100175126199
domContentLoaded190730542459229110
load202230832492217104
domInteractive190730542459229110

@brad-decker brad-decker merged commit 67eb2f9 into develop Sep 27, 2022
@brad-decker brad-decker deleted the mv3_permission_fix branch September 27, 2022 22:53
@github-actions github-actions bot locked and limited conversation to collaborators Sep 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants