remove customize-gas modal and related code that is no longer used #16004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkwing
approved these changes
Sep 28, 2022
adonesky1
approved these changes
Sep 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
I was recently reviewing old tickets for possible contributor experience issues and saw #9713. The gas buttons that this ticket refers to is the now-replaced gas UI where we displayed a slider and three buttons. During EIP-1559 v1 we changed the 'CUSTOMIZE_GAS' modal to the 'LEGACY_CUSTOMIZE_GAS' modal and the only place that called it. However in #11712 we removed the only place that opened this modal.
The only thing inside the customize gas modal folder that was used was the advanced gas input component, which I elevated out of that modal folder into app components.
This allows for the removal of the button group selector and various other selectors as well as the modal itself and related code.
More Information
Fixes #9713
Screenshots/Screencaps
Before
After
Manual Testing Steps
There should be no functional changes in this PR, the code removed was not used.
Pre-Merge Checklist