Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move getRenderableGasButtonData and refactor dependencies accordingly #9713

Closed
danjm opened this issue Oct 25, 2020 · 0 comments · Fixed by #16004
Closed

Move getRenderableGasButtonData and refactor dependencies accordingly #9713

danjm opened this issue Oct 25, 2020 · 0 comments · Fixed by #16004

Comments

@danjm
Copy link
Contributor

danjm commented Oct 25, 2020

After #9599, getRenderableGasButtonData will be used by different unrelated components. Currently it lives within the custom-gas module, but as that module is intended for use by a specific part of state and set of components, namely the gas-customization-modal components. getRenderableGasButtonData will now also be used by swaps-gas-customization-modal, and custom-gas is no longer the correct home for.

Meanwhile, getRenderableGasButtonData has a number of dependencies that also live within custom-gas that could also be moved, but can likely also be made redundant by use of one or two methods imported from our conversion utilities.

getRenderableGasButtonData should be move to its own module and its dependencies should be replaced by appropriate functions that can be imported from elsewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants