[FLASK] Snaps Insight #15814

GuillaumeRx · 2022-09-13T16:43:46Z

Explanation

All the logic and UI needed for the new Snaps Insight API.

More Information

Fixes #655

Manual Testing Steps

Clone https://github.com/GuillaumeRx/snap-tx-insight
yarn install && yarn start in the snap-tx-insight repo
connect the snap (We have a bug right now, after clicking connect and allowing the snap the connect button will still appear, no worries
Do a contract interaction (like a unsiwap swap)
Look at the tx insight tab in the tx confirmation screen

github-actions · 2022-09-13T16:44:01Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2022-09-13T17:40:35Z

Builds ready [ae73641]

builds: chrome, firefox, opera
builds (beta): chrome, firefox, opera
builds (flask): chrome, firefox, opera
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 2, 3, 4, 5, 6, 7
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1493 ± 128 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	93	1826	322	475	228
		domContentLoaded	1096	1912	1471	264	127
		load	1096	1942	1493	266	128
		domInteractive	1096	1912	1471	264	127

highlights:

storybook

metamaskbot · 2022-09-14T16:14:49Z

Builds ready [0bf2ef4]

builds: chrome, firefox, opera
builds (beta): chrome, firefox, opera
builds (flask): chrome, firefox, opera
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 2, 3, 4, 5, 6, 7
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1367 ± 81 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	98	145	116	14	7
		domContentLoaded	1190	1806	1348	161	77
		load	1190	1806	1367	168	81
		domInteractive	1190	1806	1348	161	77

highlights:

storybook

metamaskbot · 2022-09-15T17:40:17Z

Builds ready [2bd5de3]

builds: chrome, firefox, opera
builds (beta): chrome, firefox, opera
builds (flask): chrome, firefox, opera
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 2, 3, 4, 5, 6, 7
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1335 ± 38 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	89	177	116	22	10
		domContentLoaded	1197	1424	1317	68	33
		load	1205	1453	1335	78	38
		domInteractive	1197	1424	1317	68	33

highlights:

storybook

brad-decker

Almost there, I did a more thorough check for design system usage on this pass.

ui/components/app/flask/snap-content-footer/snap-content-footer.js

ui/components/app/flask/snap-content-footer/index.scss

ui/components/app/confirm-page-container/flask/snap-insight.js

ui/components/ui/tabs/dropdown-tab/dropdown-tab.js

georgewrmarshall

Component code is looking good! Well done on the propType descriptions 💯 Could we get stories for all these new UI components as well I think it would be very helpful for future iterations of the UI and review?

See how to quickly get a story up and running under "Creating a Story" here: https://metamask.github.io/metamask-storybook/index.html?path=/story/getting-started-documentation-guidelines--page

app/_locales/en/messages.json

Co-authored-by: Frederik Bolding <[email protected]>

ui/components/app/confirm-page-container/flask/snap-insight.js

ui/components/app/flask/snap-content-footer/snap-content-footer.js

ui/pages/confirm-transaction-base/confirm-transaction-base.component.js

metamaskbot · 2022-09-20T16:37:27Z

Builds ready [f2d06ec]

builds: chrome, firefox, opera
builds (beta): chrome, firefox, opera
builds (flask): chrome, firefox, opera
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 2, 3, 4, 5, 6, 7
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1640 ± 58 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	107	196	146	25	12
		domContentLoaded	1418	1926	1624	117	56
		load	1418	1926	1640	120	58
		domInteractive	1418	1926	1624	117	56

highlights:

storybook

FrederikBolding mentioned this pull request Sep 14, 2022

[FLASK] [PROTOTYPE] Snaps TX Insight #14672

Closed

GuillaumeRx force-pushed the snaps-insight branch from 9865ce1 to 2bd5de3 Compare September 15, 2022 16:42

GuillaumeRx marked this pull request as ready for review September 15, 2022 16:42

GuillaumeRx requested a review from a team as a code owner September 15, 2022 16:42

GuillaumeRx requested a review from georgewrmarshall September 15, 2022 16:42

brad-decker suggested changes Sep 15, 2022

View reviewed changes

georgewrmarshall reviewed Sep 15, 2022

View reviewed changes

app/_locales/en/messages.json Outdated Show resolved Hide resolved

app/_locales/en/messages.json Outdated Show resolved Hide resolved

hmalik88 and others added 3 commits September 20, 2022 15:01

[FLASK] Added hook and action for transaction insight snaps (#15811)

b0b522b

[FLASK] Add transaction insight footer (#15810)

63f79c4

[FLASK] Add snaps insight UI (#15809)

f6e2594

Co-authored-by: Frederik Bolding <[email protected]>

GuillaumeRx force-pushed the snaps-insight branch from 2bd5de3 to f6e2594 Compare September 20, 2022 13:02

address suggested changes

0bfba4c

ritave reviewed Sep 20, 2022

View reviewed changes

GuillaumeRx added 2 commits September 20, 2022 16:32

fix build error

a959ce8

address @ritave comments

77f2be5

GuillaumeRx requested review from ritave, brad-decker and georgewrmarshall September 20, 2022 15:13

add permission desc

f2d06ec

ritave approved these changes Sep 20, 2022

View reviewed changes

brad-decker approved these changes Sep 20, 2022

View reviewed changes

GuillaumeRx merged commit c9dc59e into develop Sep 20, 2022

GuillaumeRx deleted the snaps-insight branch September 20, 2022 17:00

github-actions bot locked and limited conversation to collaborators Sep 20, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FLASK] Snaps Insight #15814

[FLASK] Snaps Insight #15814

GuillaumeRx commented Sep 13, 2022 •

edited

Loading

github-actions bot commented Sep 13, 2022

metamaskbot commented Sep 13, 2022

metamaskbot commented Sep 14, 2022

metamaskbot commented Sep 15, 2022

brad-decker left a comment

georgewrmarshall left a comment

metamaskbot commented Sep 20, 2022

[FLASK] Snaps Insight #15814

[FLASK] Snaps Insight #15814

Conversation

GuillaumeRx commented Sep 13, 2022 • edited Loading

Explanation

More Information

Manual Testing Steps

github-actions bot commented Sep 13, 2022

metamaskbot commented Sep 13, 2022

highlights:

metamaskbot commented Sep 14, 2022

highlights:

metamaskbot commented Sep 15, 2022

highlights:

brad-decker left a comment

Choose a reason for hiding this comment

georgewrmarshall left a comment

Choose a reason for hiding this comment

metamaskbot commented Sep 20, 2022

highlights:

GuillaumeRx commented Sep 13, 2022 •

edited

Loading