Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLASK] Add snaps insight UI #15809

Merged
merged 18 commits into from
Sep 15, 2022
Merged

[FLASK] Add snaps insight UI #15809

merged 18 commits into from
Sep 15, 2022

Conversation

GuillaumeRx
Copy link
Contributor

@GuillaumeRx GuillaumeRx commented Sep 13, 2022 •
edited
Loading

Explanation

Add snaps insight UI tab in contract interactions confirm screen.

More Information

@GuillaumeRx GuillaumeRx requested a review from a team as a code owner September 13, 2022 15:21
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@GuillaumeRx GuillaumeRx changed the base branch from develop to snaps-insight September 13, 2022 15:37
hmalik88
hmalik88 approved these changes Sep 13, 2022
View reviewed changes
Copy link
Contributor

@hmalik88 hmalik88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

brad-decker
brad-decker suggested changes Sep 15, 2022
View reviewed changes
Copy link
Contributor

@brad-decker brad-decker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

filename nits mostly, looks good otherwise

ui/components/ui/tabs/dropdown-tab/dropdown-tab.component.js Outdated Show resolved Hide resolved
ui/components/app/confirm-page-container/flask/snap-insight.component.js Outdated Show resolved Hide resolved
@metamaskbot
Copy link
Collaborator

Builds ready [e98ded7]
Page Load Metrics (1243 ± 38 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint86137101136
domContentLoaded1121143112277335
load1140143112437838
domInteractive1121143112277335

highlights:

storybook

@GuillaumeRx GuillaumeRx merged commit 9865ce1 into snaps-insight Sep 15, 2022
@GuillaumeRx GuillaumeRx deleted the gr/snaps-insight-ui branch September 15, 2022 16:40
@github-actions github-actions bot locked and limited conversation to collaborators Sep 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hmalik88 hmalik88 hmalik88 approved these changes

@brad-decker brad-decker brad-decker requested changes

@NidhiKJha NidhiKJha Awaiting requested review from NidhiKJha NidhiKJha was automatically assigned from MetaMask/extension-devs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrate Transaction Insight into the MetaMask Extension UI
5 participants
@GuillaumeRx @metamaskbot @brad-decker @hmalik88 @FrederikBolding