Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update zh_TW translation with common terms used in Taiwan #11636

Closed
wants to merge 16 commits into from
Closed

Update zh_TW translation with common terms used in Taiwan #11636

wants to merge 16 commits into from

Conversation

hydai
Copy link

@hydai hydai commented Jul 27, 2021

Explanation:
I found that translation of zh_TW missed lots of strings and used non-common terms. So I synced the strings with the latest en/message.json and updated the Traditional Chinese terms with our common terms.

@hydai hydai requested a review from a team as a code owner July 27, 2021 17:49
@hydai hydai requested a review from darkwing July 27, 2021 17:49
@github-actions
Copy link
Contributor

github-actions bot commented Jul 27, 2021 •
edited
Loading

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@hydai
Copy link
Author

hydai commented Jul 27, 2021

I have read the CLA Document and I hereby sign the CLA

@hydai hydai force-pushed the hydai/update_zh_TW_translation branch 4 times, most recently from e8974b8 to 8685509 Compare August 3, 2021 13:15
@hydai
Copy link
Author

hydai commented Aug 3, 2021

Hi @darkwing

I've rebased this branch to latest develop branch and all checks have passed.
I would like to know if I need to do anything else to get this PR reviewed. Thanks.

@andy0130tw
Copy link
Contributor

andy0130tw commented Sep 29, 2021 •
edited
Loading

Hi @hydai,

I also happened to contribute a localization file update for zh_TW at PR #11212. As the PR becoming stale, I am considering retreating my PR instead of doing rebases. I wonder if we can collaborate on the localization work?

@hydai
Copy link
Author

hydai commented Oct 1, 2021

Hi @andy0130tw
That will be great. If we can collaborate on this work.

And I have no idea what's the localization process in MetaMask. Should I create an issue or work item at another place?

@darkwing darkwing added the area-translation Issues relating to translating the app into various languages. label Nov 6, 2021
@hydai hydai force-pushed the hydai/update_zh_TW_translation branch 3 times, most recently from 013b0e0 to 0edd71e Compare December 14, 2021 16:02
@mcmire
Copy link
Contributor

mcmire commented Jan 6, 2022

Hey, sorry it's taken us so long to get back to you. We have a lot of new translations coming in via #13206, so I'll wait until that's merged first.

@mcmire mcmire added the blocked label Jan 6, 2022
@brad-decker brad-decker dismissed stale reviews from ghost via fbe4a19 September 16, 2022 14:13
@brad-decker brad-decker force-pushed the hydai/update_zh_TW_translation branch 2 times, most recently from fbe4a19 to 87c4f2e Compare September 16, 2022 14:14
@brad-decker
Copy link
Contributor

@hydai Thanks for all the work here. I took over and did a rebase. I spot checked the translations to the best of my ability and any where you added translations that our translation service had also added I erred towards our translation service. I removed a few items that were the english versions because our translations system falls back to showing english if a key is missing for a locale. Thanks again, i'll try and get this approved and merged soon!

brad-decker
brad-decker previously approved these changes Sep 16, 2022
View reviewed changes
@brad-decker brad-decker force-pushed the hydai/update_zh_TW_translation branch from 87c4f2e to eb14719 Compare November 16, 2022 17:27
@brad-decker
Copy link
Contributor

Okay cleaned this up again. I'm going to seek a native speaker to check these translations as we now have multiple sources offering different translations. @hydai if you could review the translations and remove any you think are already accurate that would greatly improve our review time.

yahsinhuangtw
yahsinhuangtw previously approved these changes Nov 19, 2022
View reviewed changes
Copy link
Contributor

@yahsinhuangtw yahsinhuangtw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed a few terms were not translated. One additional translation was provided. Overall, the translation sounds natural. Appreciate the work of traditional Mandarin language translation for Taiwan.

app/_locales/zh_TW/messages.json Outdated Show resolved Hide resolved
brad-decker
brad-decker previously approved these changes Nov 19, 2022
View reviewed changes
hydai
hydai commented Nov 23, 2022
View reviewed changes
Copy link
Author

@hydai hydai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @brad-decker
I just updated some wording. And the remaining part should be fine. Thanks for the review and assistance.

app/_locales/zh_TW/messages.json Outdated Show resolved Hide resolved
app/_locales/zh_TW/messages.json Outdated Show resolved Hide resolved
app/_locales/zh_TW/messages.json Outdated Show resolved Hide resolved
app/_locales/zh_TW/messages.json Outdated Show resolved Hide resolved
legobeat
legobeat previously approved these changes May 3, 2023
View reviewed changes
@github-actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity in the last 60 days. It will be closed in 14 days. Thank you for your contributions.

@github-actions github-actions bot added the stale issues and PRs marked as stale label Jul 24, 2023
@hydai
Copy link
Author

hydai commented Jul 24, 2023

Hi @legobeat
This PR has been stale for a long time. Would you still like to merge it?

@github-actions github-actions bot removed the stale issues and PRs marked as stale label Jul 25, 2023
@github-actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity in the last 60 days. It will be closed in 14 days. Thank you for your contributions.

@github-actions github-actions bot added the stale issues and PRs marked as stale label Sep 23, 2023
@hydai
Copy link
Author

hydai commented Sep 25, 2023

Hi @legobeat
I resolved the conflicts. PTAL.

@hydai hydai force-pushed the hydai/update_zh_TW_translation branch from 9054081 to eef9905 Compare September 25, 2023 17:48
@github-actions github-actions bot removed the stale issues and PRs marked as stale label Sep 25, 2023
@github-actions GitHub Actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity in the last 60 days. It will be closed in 14 days. Thank you for your contributions.

@github-actions github-actions bot added the stale issues and PRs marked as stale label Nov 24, 2023
@legobeat legobeat requested review from a team and DDDDDanica November 24, 2023 21:42
@github-actions github-actions bot removed the stale issues and PRs marked as stale label Nov 24, 2023
@github-actions GitHub Actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity in the last 60 days. It will be closed in 14 days. Thank you for your contributions.

@github-actions github-actions bot added the stale issues and PRs marked as stale label Jan 23, 2024
@legobeat legobeat removed the stale issues and PRs marked as stale label Jan 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity in the last 60 days. It will be closed in 14 days. Thank you for your contributions.

@github-actions github-actions bot added the stale issues and PRs marked as stale label Mar 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 7, 2024

This PR was closed because there has been no follow up activity in the last 14 days. Thank you for your contributions.

@github-actions github-actions bot closed this Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yahsinhuangtw yahsinhuangtw yahsinhuangtw approved these changes

@legobeat legobeat legobeat left review comments

@darkwing darkwing Awaiting requested review from darkwing

@brad-decker brad-decker Awaiting requested review from brad-decker

@DDDDDanica DDDDDanica Awaiting requested review from DDDDDanica

Assignees
No one assigned
Labels
area-translation Issues relating to translating the app into various languages. blocked stale issues and PRs marked as stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@hydai @andy0130tw @mcmire @brad-decker @legobeat @yahsinhuangtw @darkwing