[i18n:zh_tw] Sync and update translation for zh_TW #11212

andy0130tw · 2021-05-30T16:23:41Z

This patch translates essentially all strings to locale zh_TW, with the following topics excluded:

GDPR messages (gdprMessage and gdprMessagePrivacyPolicy)
MetaMask Swaps (keys beginning with "swap")
MetaMetrics (keys beginning with "metametrics") -- I am not confident on translating these messages precisely

In addition, a variety of fixes are applied to improve existing translation strings.

Sync all missing strings from en strings at v9.5.7.
Update some strings where the corresponding message has changed over time (e.g., readdToken).
Fix some inappropriate punctuations (e.g., missing trailing periods).
Use more common/agreed terms used in Taiwan (合約、助憶詞、帳戶、函式、...).

I translate these blockchain-related terminologies to the best of my knowledge, but I am open to any adjustments.

andy0130tw · 2021-06-02T16:18:24Z

I guess I should comment here for the CLA bot to access.

Update: It does not work.

andy0130tw · 2021-06-03T09:36:32Z

I have read the CLA Document and I hereby sign the CLA.

mcmire · 2022-01-06T22:44:19Z

Hey, sorry it's taken us so long to get back to you. We have a lot of new translations coming in via #13206, so I'll wait until that's merged first.

github-actions · 2022-01-06T22:44:34Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

brad-decker · 2022-11-04T14:57:50Z

@andy0130tw thanks for your patience and apologies for the delayed response. The translation system is now active but we still welcome community translations.If you want to see this landed please rebase and resolve conflicts, then tag me for review. Thank you!

andy0130tw · 2022-11-05T15:09:01Z

I resolved conflicts and rebased my translation against the most recent commit. The PR is ready to be merged (again). Due to the fact that it has been long time since I last worked on this, I patched some small edits I spotted and decided to leave new strings as-is.

brad-decker · 2022-11-07T21:56:31Z

app/_locales/zh_TW/messages.json

+    "message": "Incongruent transaction data. Please check the transaction details."
+  },
+  "QRHardwarePubkeyAccountOutOfRange": {
+    "message": "No more accounts. If you would like to access another account unlisted below, please reconnect your hardware wallet and select it."
+  },
+  "QRHardwareScanInstructions": {
+    "message": "Place the QR code in front of your camera. The screen is blurred, but it will not affect the reading."
+  },
+  "QRHardwareSignRequestCancel": {
+    "message": "Reject"
+  },
+  "QRHardwareSignRequestDescription": {
+    "message": "After you’ve signed with your wallet, click on 'Get Signature' to receive the signature"
+  },
+  "QRHardwareSignRequestGetSignature": {
+    "message": "Get Signature"
+  },
+  "QRHardwareSignRequestSubtitle": {
+    "message": "Scan the QR code with your wallet"
+  },
+  "QRHardwareSignRequestTitle": {
+    "message": "Request Signature"
+  },
+  "QRHardwareUnknownQRCodeTitle": {
+    "message": "Error"
+  },
+  "QRHardwareUnknownWalletQRCode": {
+    "message": "Invalid QR code. Please scan the sync QR code of the hardware wallet."
+  },
+  "QRHardwareWalletImporterTitle": {
+    "message": "Scan QR Code"
+  },
+  "QRHardwareWalletSteps1Description": {
+    "message": "Connect an airgapped hardware wallet that communicates through QR-codes. Officially supported airgapped hardware wallets include:"
+  },
+  "QRHardwareWalletSteps1Title": {
+    "message": "QR-based HW Wallet"
+  },
+  "QRHardwareWalletSteps2Description": {
+    "message": "AirGap Vault & Ngrave (Coming Soon)"
+  },
+  "SIWEAddressInvalid": {
+    "message": "The address in the sign-in request does not match the address of the account you are using to sign in."
+  },
+  "SIWEDomainInvalidText": {
+    "message": "The site you're attempting to sign into doesn't match the domain in the request. Proceed with caution."
+  },
+  "SIWEDomainInvalidTitle": {
+    "message": "Deceptive site request."
+  },
+  "SIWEDomainWarningBody": {
+    "message": "The website ($1) is asking you to sign in to the wrong domain. This may be a phishing attack.",
+    "description": "$1 represents the website domain"
+  },
+  "SIWEDomainWarningLabel": {
+    "message": "Unsafe"
+  },
+  "SIWELabelChainID": {
+    "message": "Chain ID:"
+  },
+  "SIWELabelExpirationTime": {
+    "message": "Expires At:"
+  },
+  "SIWELabelIssuedAt": {
+    "message": "Issued At:"
+  },
+  "SIWELabelMessage": {
+    "message": "Message:"
+  },
+  "SIWELabelNonce": {
+    "message": "Nonce:"
+  },
+  "SIWELabelNotBefore": {
+    "message": "Not Before:"
+  },
+  "SIWELabelRequestID": {
+    "message": "Request ID:"
+  },
+  "SIWELabelResources": {
+    "message": "Resources: $1",
+    "description": "$1 represents the number of resources"
+  },
+  "SIWELabelURI": {
+    "message": "URI:"
+  },
+  "SIWELabelVersion": {
+    "message": "Version:"
+  },
+  "SIWESiteRequestSubtitle": {
+    "message": "This site is requesting to sign in with"
+  },
+  "SIWESiteRequestTitle": {
+    "message": "Sign-in request"
+  },
+  "SIWEWarningSubtitle": {
+    "message": "To confirm you understand, check:"
+  },
+  "SIWEWarningTitle": {
+    "message": "Are you sure?"
+  },


For any keys that are just using the english message please remove those keys, the system falls back to using the english translation when not present for the language.

OK. I will remove these keys and rebase again.

I have removed redundant keys accordingly.

Synced from en strings at commit 646dbaa (unreleased since v10.21.1).

brad-decker · 2022-11-11T14:23:28Z

Thanks @andy0130tw :D -- approved and will seek an additional approval for merge.

andy0130tw requested a review from a team as a code owner May 30, 2021 16:23

andy0130tw requested a review from PeterYinusa May 30, 2021 16:23

andy0130tw force-pushed the update-translation-zh-tw branch from ad1c05a to bcb605e Compare May 31, 2021 08:03

andy0130tw mentioned this pull request Sep 29, 2021

Update zh_TW translation with common terms used in Taiwan #11636

Closed

darkwing added the area-translation Issues relating to translating the app into various languages. label Nov 6, 2021

mcmire added the blocked label Jan 6, 2022

andy0130tw force-pushed the update-translation-zh-tw branch from 048424f to 7bd805a Compare January 10, 2022 21:02

kumavis removed the blocked label Jul 30, 2022

kumavis changed the title ~~Sync and update translation for zh_TW~~ [i18n:zh_tw] Sync and update translation for zh_TW Jul 30, 2022

andy0130tw dismissed a stale review via 9c8a035 November 5, 2022 14:22

andy0130tw force-pushed the update-translation-zh-tw branch 3 times, most recently from 6cab392 to 1a030be Compare November 5, 2022 15:04

brad-decker suggested changes Nov 7, 2022

View reviewed changes

andy0130tw force-pushed the update-translation-zh-tw branch 3 times, most recently from 4ab2667 to e7f53bd Compare November 8, 2022 04:57

Sync and update translation for zh_TW

a70c655

Synced from en strings at commit 646dbaa (unreleased since v10.21.1).

andy0130tw force-pushed the update-translation-zh-tw branch from e7f53bd to a70c655 Compare November 8, 2022 04:59

andy0130tw requested review from brad-decker and removed request for PeterYinusa November 11, 2022 10:28

brad-decker approved these changes Nov 11, 2022

View reviewed changes

Merge branch 'develop' into update-translation-zh-tw

80a1a3a

segun approved these changes Nov 14, 2022

View reviewed changes

brad-decker merged commit 4937bb4 into MetaMask:develop Nov 14, 2022

github-actions bot locked and limited conversation to collaborators Nov 14, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[i18n:zh_tw] Sync and update translation for zh_TW #11212

[i18n:zh_tw] Sync and update translation for zh_TW #11212

andy0130tw commented May 30, 2021

andy0130tw commented Jun 2, 2021 •

edited

Loading

andy0130tw commented Jun 3, 2021

mcmire commented Jan 6, 2022 •

edited

Loading

github-actions bot commented Jan 6, 2022

brad-decker commented Nov 4, 2022

andy0130tw commented Nov 5, 2022

brad-decker Nov 7, 2022

andy0130tw Nov 8, 2022

andy0130tw Nov 8, 2022

brad-decker commented Nov 11, 2022

[i18n:zh_tw] Sync and update translation for zh_TW #11212

[i18n:zh_tw] Sync and update translation for zh_TW #11212

Conversation

andy0130tw commented May 30, 2021

andy0130tw commented Jun 2, 2021 • edited Loading

andy0130tw commented Jun 3, 2021

mcmire commented Jan 6, 2022 • edited Loading

github-actions bot commented Jan 6, 2022

brad-decker commented Nov 4, 2022

andy0130tw commented Nov 5, 2022

brad-decker Nov 7, 2022

Choose a reason for hiding this comment

andy0130tw Nov 8, 2022

Choose a reason for hiding this comment

andy0130tw Nov 8, 2022

Choose a reason for hiding this comment

brad-decker commented Nov 11, 2022

andy0130tw commented Jun 2, 2021 •

edited

Loading

mcmire commented Jan 6, 2022 •

edited

Loading