Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "Update Network: should update added rpc url for exis..." flaky tests #27422

Open
hjetpoluru opened this issue Sep 26, 2024 · 2 comments
Open

Fix "Update Network: should update added rpc url for exis..." flaky tests #27422

hjetpoluru opened this issue Sep 26, 2024 · 2 comments
Assignees
@hjetpoluru
Labels
flaky tests Sev2-normal Normal severity; minor loss of service or inconvenience. team-extension-platform type-bug

Comments

@hjetpoluru
Copy link
Contributor

https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/102184/workflows/bfe4044c-c8e3-4592-b72b-6442957fc42a/jobs/3807212/tests

Build - Regular
Browser - Firefox
Test scenario - Update Network: should update added rpc url for existing network
Test Path - /test/e2e/tests/network/update-network.spec.ts

ElementClickInterceptedError: Element <button class="mm-box mm-picker-network multichain-app-header__contents__network-picker mm-box--margin-2 mm-box--padding-right-4 mm-box--padding-left-2 mm-box--display-none mm-box--sm:display-flex mm-box--gap-2 mm-box--align-items-center mm-box--background-color-background-alternative mm-box--rounded-pill"> is not clickable at point (218,125) because another element <div class="popover-bg"> obscures it
  (Ran on CircleCI Node 13 of 24, Job test-e2e-firefox)
    at Object.throwDecodedError (node_modules/selenium-webdriver/lib/error.js:524:15)
    at parseHttpResponse (node_modules/selenium-webdriver/lib/http.js:601:13)
    at Executor.execute (node_modules/selenium-webdriver/lib/http.js:529:28)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async thenableWebDriverProxy.execute (node_modules/selenium-webdriver/lib/webdriver.js:745:17)
    at async element.click (test/e2e/webdriver/driver.js:94:9)
    at async Driver.clickElement (test/e2e/webdriver/driver.js:579:9)
    at async /home/circleci/project/test/e2e/tests/network/update-network.spec.ts:2:9037
    at async withFixtures (test/e2e/helpers.js:217:5)
    at async Context.<anonymous> (test/e2e/tests/network/update-network.spec.ts:2:7120)

image
@hjetpoluru hjetpoluru added type-bug Sev2-normal Normal severity; minor loss of service or inconvenience. team-extension-platform flaky tests labels Sep 26, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team Sep 26, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Sep 26, 2024
@hjetpoluru hjetpoluru mentioned this issue Sep 26, 2024
Merged
7 tasks
@chloeYue chloeYue mentioned this issue Sep 27, 2024
Closed
9 tasks
@hjetpoluru hjetpoluru self-assigned this Oct 3, 2024
github-merge-queue bot pushed a commit that referenced this issue Oct 15, 2024
@hjetpoluru @seaona
fix: "Update Network: should update added rpc url for exis..." flaky …
bd018b2 
…tests (#27437)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

This PR addresses a flaky test issue caused by a popover dialog that
appears. The presence of this popover dialog prevents the test from
interacting with the intended element leading to test failures.

To resolve this, I have included the clickSafeElement method to safely
click the "Got it" button on the popover dialog.

![image](https://github.com/user-attachments/assets/5eb874d5-65bd-423a-aeab-6bf2cb628081)


<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27437?quickstart=1)

## **Related issues**

Fixes:
#27422

## **Manual testing steps**

Run the test using below commands locally or in codespaces:
yarn
yarn build:test:webpack
ENABLE_MV3=false yarn test:e2e:single
test/e2e/tests/network/update-network.spec.ts --browser=chrome

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: seaona <[email protected]>
@hjetpoluru
Copy link
Contributor Author

Fixed in PR #27437

@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by severity Oct 21, 2024
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by team Oct 21, 2024
@hjetpoluru
Copy link
Contributor Author

It has flaked again and re-opening the issue.

@hjetpoluru hjetpoluru reopened this Oct 29, 2024
@github-project-automation github-project-automation bot moved this from Fixed to To be fixed in Bugs by team Oct 29, 2024
@hjetpoluru hjetpoluru mentioned this issue Oct 31, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hjetpoluru hjetpoluru

Labels
flaky tests Sev2-normal Normal severity; minor loss of service or inconvenience. team-extension-platform type-bug
Projects
Bugs by severity
Archived in project
Bugs by team
Status: To be fixed
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hjetpoluru