fix: "Update Network: should update added rpc url for exis..." flaky …

…tests (#27437)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

This PR addresses a flaky test issue caused by a popover dialog that
appears. The presence of this popover dialog prevents the test from
interacting with the intended element leading to test failures.

To resolve this, I have included the clickSafeElement method to safely
click the "Got it" button on the popover dialog.

![image](https://github.com/user-attachments/assets/5eb874d5-65bd-423a-aeab-6bf2cb628081)


<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27437?quickstart=1)

## **Related issues**

Fixes:
#27422

## **Manual testing steps**

Run the test using below commands locally or in codespaces:
yarn
yarn build:test:webpack
ENABLE_MV3=false yarn test:e2e:single
test/e2e/tests/network/update-network.spec.ts --browser=chrome

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: seaona <[email protected]>

test/e2e/tests/network/update-network.spec.ts

@@ -240,7 +240,13 @@ describe('Update Network:', function (this: Suite) {
 
         //  Re-open the network menu
         await driver.delay(regularDelayMs);
+        // We need to use clickElementSafe + assertElementNotPresent as sometimes the network dialog doesn't appear, as per this issue (#27870)
+        // TODO: change the 2 actions for clickElementAndWaitToDisappear, once the issue is fixed
         await driver.clickElementSafe({ text: 'Got it', tag: 'h6' });
+        await driver.assertElementNotPresent({
+          tag: 'h6',
+          text: 'Got it',
+        });
         await driver.clickElement('[data-testid="network-display"]');
 
         // Go back to edit the network
@@ -360,6 +366,13 @@ describe('Update Network:', function (this: Suite) {
 
         //  Re-open the network menu
         await driver.delay(regularDelayMs);
+        // We need to use clickElementSafe + assertElementNotPresent as sometimes the network dialog doesn't appear, as per this issue (#27870)
+        // TODO: change the 2 actions for clickElementAndWaitToDisappear, once the issue is fixed
+        await driver.clickElementSafe({ text: 'Got it', tag: 'h6' });
+        await driver.assertElementNotPresent({
+          tag: 'h6',
+          text: 'Got it',
+        });
         await driver.clickElement('[data-testid="network-display"]');
 
         // Go back to edit the network