Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert MetaMetricsController (implementation + tests) to TypeScript #25924

Closed
1 of 9 tasks
mcmire opened this issue Jul 18, 2024 · 0 comments · Fixed by #28072
Closed
1 of 9 tasks

Convert MetaMetricsController (implementation + tests) to TypeScript #25924

mcmire opened this issue Jul 18, 2024 · 0 comments · Fixed by #28072
Assignees
@cryptodev-2s
Labels
release-12.7.0 Issue or pull request that will be included in release 12.7.0 team-wallet-framework

Comments

@mcmire
Copy link
Contributor

mcmire commented Jul 18, 2024 •
edited
Loading

What is this about?

As a prerequisite for migrating MetaMetricsController to BaseController v2, and to support the TypeScript migration effort for the extension, we want to convert MetaMetricsController to TypeScript.

Scenario

No response

Design

No response

Technical Details

No response

Threat Modeling Framework

No response

Acceptance Criteria

  • All functions and methods are annotated with argument and return types.
  • All properties and free variables are annotated with types.
  • # is used for private properties and methods instead of _.
  • The test file is converted to TypeScript along with the implementation file.

Stakeholder review needed before the work gets merged

  • Engineering (needed in most cases)
  • Design
  • Product
  • QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
  • Security
  • Legal
  • Marketing
  • Management (please specify)
  • Other (please specify)

References
@metamaskbot metamaskbot added the INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. label Jul 18, 2024
@mcmire mcmire mentioned this issue Jul 18, 2024
Open
29 tasks
@desi desi removed the INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. label Sep 6, 2024
@cryptodev-2s cryptodev-2s self-assigned this Sep 18, 2024
@cryptodev-2s cryptodev-2s mentioned this issue Oct 24, 2024
Merged
7 tasks
github-merge-queue bot pushed a commit that referenced this issue Oct 28, 2024
@cryptodev-2s
feat: convert MetaMetricsController to typescript (#28072)
317d2ef 
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

This PR converts MetaMetricsContrller to typescript
<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/28072?quickstart=1)

## **Related issues**

Fixes: #25924 

## **Manual testing steps**

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@metamaskbot metamaskbot added the release-12.7.0 Issue or pull request that will be included in release 12.7.0 label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cryptodev-2s cryptodev-2s

Labels
release-12.7.0 Issue or pull request that will be included in release 12.7.0 team-wallet-framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: convert MetaMetricsController to typescript MetaMask/metamask-extension
4 participants
@mcmire @desi @metamaskbot @cryptodev-2s