Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert partial level 2 files to typescript for contributing to metamask-controller.js #23018

Open
DDDDDanica opened this issue Feb 16, 2024 · 1 comment
Labels
INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. team-extension-platform

Comments

@DDDDDanica
Copy link
Contributor

DDDDDanica commented Feb 16, 2024

Convert dependency of files for metamask-controller.js (level 2) we want to target based on typescript migration dashboard.

Level 2

  • app/scripts/controllers/ens/index.js
  • app/scripts/controllers/metametrics.js
  • app/scripts/controllers/swaps.js
  • app/scripts/lib/ComposableObservableStore.js
  • app/scripts/lib/createMetaRPCHandler.js
  • app/scripts/lib/createRPCMethodTrackingMiddleware.js

will be tackled by shared library team in another ticket:
Removed - app/scripts/controllers/detect-tokens.js

@DDDDDanica DDDDDanica added the INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. label Feb 16, 2024
@DDDDDanica DDDDDanica changed the title Copy of Convert partial level 3 files to typescript for contributing to metamask-controller.js Convert partial level 2 files to typescript for contributing to metamask-controller.js Feb 16, 2024
@DDDDDanica DDDDDanica added team-extension-platform and removed INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. labels Feb 16, 2024
@metamaskbot metamaskbot added the INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. label Mar 5, 2024
@DDDDDanica DDDDDanica removed the INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. label Mar 12, 2024
@metamaskbot metamaskbot added the INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. label Mar 12, 2024
@MajorLift
Copy link
Contributor

Heads up on some items here that overlap with Shared Libraries work (cc. @desi):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. team-extension-platform
Projects
None yet
Development

No branches or pull requests

3 participants